[GitHub] cloudstack pull request: zip the processed json files so we save d...

[remibergsma]

Github user remibergsma closed the pull request at:

https://github.com/apache/cloudstack/pull/1421


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: zip the processed json files so we save d...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1421#issuecomment-217497179
  
any suggestions for how to test this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: zip the processed json files so we save d...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1421#issuecomment-216285170
  
How do I test this and verify it is working?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: zip the processed json files so we save d...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1421#issuecomment-216273377
  
@remibergsma requires force push again.  Travis timed out...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: zip the processed json files so we save d...

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1421#issuecomment-216224495
  
LGTM

tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: zip the processed json files so we save d...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1421#issuecomment-216030620
  
Force pushed again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: zip the processed json files so we save d...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1421#issuecomment-215988060
  
@swill force pushed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: zip the processed json files so we save d...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1421#issuecomment-187054205
  
LGTM, based on the code and the presented output.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: zip the processed json files so we save d...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1421#discussion_r53593074
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/merge.py ---
@@ -272,5 +275,10 @@ def setPath(self, path):
 def __moveFile(self, origPath, path):
 if not os.path.exists(path):
 os.makedirs(path)
-timestamp = str(int(round(time.time(
-os.rename(origPath, path + "/" + self.fileName + "." + timestamp)
+
+zipped_file_name = path + "/" + self.fileName + "." + 
str(uuid.uuid4()) + ".gz"
--- End diff --

Ok, just an idea


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: zip the processed json files so we save d...

[remibergsma]

Github user remibergsma commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1421#discussion_r53555783
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/merge.py ---
@@ -272,5 +275,10 @@ def setPath(self, path):
 def __moveFile(self, origPath, path):
 if not os.path.exists(path):
 os.makedirs(path)
-timestamp = str(int(round(time.time(
-os.rename(origPath, path + "/" + self.fileName + "." + timestamp)
+
+zipped_file_name = path + "/" + self.fileName + "." + 
str(uuid.uuid4()) + ".gz"
--- End diff --

The filename becomes quite long in that case. The date is already in the 
meta data of the file, so one could use `ls -latr` to get it:

![screen shot 2016-02-20 at 20 29 
02](https://cloud.githubusercontent.com/assets/1630096/13198719/aa0d1982-d810-11e5-88c5-d833d738a442.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: zip the processed json files so we save d...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1421#discussion_r53555684
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/merge.py ---
@@ -272,5 +275,10 @@ def setPath(self, path):
 def __moveFile(self, origPath, path):
 if not os.path.exists(path):
 os.makedirs(path)
-timestamp = str(int(round(time.time(
-os.rename(origPath, path + "/" + self.fileName + "." + timestamp)
+
+zipped_file_name = path + "/" + self.fileName + "." + 
str(uuid.uuid4()) + ".gz"
--- End diff --

would it make sense to have the timestamp in the filename as well? for easy 
ordering


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: zip the processed json files so we save d...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1421#issuecomment-186664554
  
Test result:
![screen shot 2016-02-20 at 19 35 
42](https://cloud.githubusercontent.com/assets/1630096/13198466/8c0c4b9e-d809-11e5-883b-b37b4beb53d9.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: zip the processed json files so we save d...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1421

zip the processed json files so we save diskspace

Zip the processed json files and make sure they're unique (timestamp is not 
unique).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack 
gzip-processed-json-router-config

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1421.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1421


commit 8b037169cbfc7f0e699ee593dd09f27f89a9
Author: Boris Schrijver 
Date:   2016-02-20T12:39:42Z

zip the processed json files so we save diskspace




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---