Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110854129
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -848,13 +849,38 @@ public int compare(final PublicIpAddress o1, final
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110854097
--- Diff: setup/db/db/schema-4920to41000.sql ---
@@ -230,5 +230,11 @@ JOIN `cloud`.`vm_snapshots` s ON
(s.service_offering_id = o.id AND s.vm_id = v.i
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110854055
--- Diff: setup/db/db/schema-4920to41000.sql ---
@@ -230,5 +230,11 @@ JOIN `cloud`.`vm_snapshots` s ON
(s.service_offering_id = o.id AND s.vm_id = v.i
Github user ProjectMoon commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110848750
--- Diff: setup/db/db/schema-4920to41000.sql ---
@@ -230,5 +230,11 @@ JOIN `cloud`.`vm_snapshots` s ON
(s.service_offering_id = o.id AND s.vm_id =
Github user ProjectMoon commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110849362
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -848,13 +849,38 @@ public int compare(final PublicIpAddress o1, final
Github user ProjectMoon commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110848709
--- Diff: setup/db/db/schema-4920to41000.sql ---
@@ -230,5 +230,11 @@ JOIN `cloud`.`vm_snapshots` s ON
(s.service_offering_id = o.id AND s.vm_id =
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110818988
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -625,15 +627,20 @@ protected
Github user ProjectMoon commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110113725
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -625,15 +627,20 @@ protected
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110112007
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -848,13 +849,37 @@ public int compare(final PublicIpAddress o1, final
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r11089
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -848,13 +849,37 @@ public int compare(final PublicIpAddress o1, final
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110082664
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -1764,9 +1765,12 @@ protected
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110082657
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -625,15 +627,20 @@ protected
Github user ProjectMoon commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r106855504
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -1764,9 +1765,12 @@ protected
Github user ProjectMoon commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r106856634
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -848,13 +849,37 @@ public int compare(final PublicIpAddress o1, final
Github user ProjectMoon commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r106855300
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -625,15 +627,20 @@ protected
Github user ProjectMoon commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r106857110
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -848,13 +849,37 @@ public int compare(final PublicIpAddress o1, final
Github user ProjectMoon commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r105130816
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -625,15 +627,20 @@ protected
Github user ProjectMoon commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r101736186
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -175,6 +176,8 @@
@Inject
private IPAddressDao
Github user ProjectMoon commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r100535848
--- Diff: setup/db/db/schema-4920to41000.sql ---
@@ -62,3 +62,4 @@ INSERT INTO `cloud`.`role_permissions` (`uuid`,
`role_id`, `rule`, `permission`,
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r99469241
--- Diff: core/src/com/cloud/agent/api/routing/NetworkElementCommand.java
---
@@ -38,6 +38,7 @@
public static final String
Github user yvsubhash commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r96598944
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -823,13 +826,39 @@ public int compare(final PublicIpAddress o1, final
GitHub user jayapalu opened a pull request:
https://github.com/apache/cloudstack/pull/1908
CLOUDSTACK-9317: Fixed disable static nat on leaving ips on interface
FIxed issue in disabling multiple static nat simultaneously.
This patch has taken changes from the PR 1450 and
22 matches
Mail list logo
