Hello all, I submitted PR 1500 this morning that addresses JIRA issue CLOUDSTACK-9349 around KVM Root Volume detach/attach. This was really a very minor code change to java, but I also submitted a marvin integration test that I would love to get some feedback on. This was my first pass at writing a marvin unit test and I did my best to follow the same style I saw in test_volumes.py, but again I would love to have someone more familiar with marvin take a look and make sure everything looks right to them.
Please see the original PR submission below for more details. Thanks in advance for the feedback. Thanks, David Mabry On 4/18/16, 8:20 AM, "dmabry" <g...@git.apache.org> wrote: >GitHub user dmabry opened a pull request: > > https://github.com/apache/cloudstack/pull/1500 > > CLOUDSTACK-9349 > > This PR addresses the KVM detach/attach ROOT disks from VMs > (CLOUDSTACK-9349). In short, this allows the KVM Hypervisor, and I added the > Simulator as a valid hypervisor for ease of development and testing of > marvin, to detach a root volume and the reattach a root volume using the > deviceid=0 flag to the attachVolume API. I have also written a marvin > integration test that verifies this feature works for both KVM and the > Simulator. > > Below is the marvin results files of the full marvin test_volumes.py. All > tests pass, including the new root detach/attach, on our KVM lab running with > the patches in this PR. > > > [test_volumes_KIR4G3.zip](https://github.com/apache/cloudstack/files/223799/test_volumes_KIR4G3.zip) > > >You can merge this pull request into a Git repository by running: > > $ git pull https://github.com/myENA/cloudstack KVM_root_detach > >Alternatively you can review and apply these changes as the patch at: > > https://github.com/apache/cloudstack/pull/1500.patch > >To close this pull request, make a commit to your master/trunk branch >with (at least) the following in the commit message: > > This closes #1500 > >---- >commit 48ce76344040de2ab8014f76292abe0421d42f85 >Author: Simon Weller <siwelle...@gmail.com> >Date: 2016-03-24T19:55:34Z > > Merge pull request #4 from apache/4.7 > > 4.7 PR > >commit d0a02640dfd4878da81a2e59588c4b5ff2a06401 >Author: Simon Weller <swel...@ena.com> >Date: 2016-04-14T13:28:37Z > > Let hypervisor type KVM detach root volumes > >commit 7807955433cea390bb7358e3bb90dbc9cc06bbea >Author: David Mabry <dma...@ena.com> >Date: 2016-04-15T12:30:07Z > > updated test_volumes.py to include a test for detaching and reattaching a > root volume from a vm. I also had to update base.py to all attach_volume to > have the parameter deviceid to be passed as needed. > >commit d7d55630daff4a5e17c9a374dc2e9bc478dff808 >Author: David Mabry <dma...@ena.com> >Date: 2016-04-18T02:41:29Z > > Added Simulator as valid hypervisor for root detach > >---- > > >--- >If your project is set up for it, you can reply to this email and have your >reply appear on GitHub as well. If your project does not have this feature >enabled and wishes so, or if the feature is enabled but not working, please >contact infrastructure at infrastruct...@apache.org or file a JIRA ticket >with INFRA. >---
