Re: [2.1.10] WildcardHelperTestCase fails

2006-12-07 Thread Alfred Nathaniel
On Wed, 2006-12-06 at 08:34 +0100, Carsten Ziegeler wrote: Ok, I removed the usage of the deprecated matching code and replaced it with using the new matcher. In addition I removed the duplicate test case for the WildcardHelper class and commented out the failing test in the remaining test

Re: [2.1.10] WildcardHelperTestCase fails

2006-12-07 Thread Carsten Ziegeler
Alfred Nathaniel wrote: On Wed, 2006-12-06 at 08:34 +0100, Carsten Ziegeler wrote: Ok, I removed the usage of the deprecated matching code and replaced it with using the new matcher. In addition I removed the duplicate test case for the WildcardHelper class and commented out the failing test

Re: [2.1.10] WildcardHelperTestCase fails

2006-12-05 Thread Carsten Ziegeler
Afaik, the code for the wildcard helper has been replaced after that by someone else. Carsten Bertrand Delacretaz wrote: Just tried to run the junit tests on BRANCH_2_1_X, and the second assertion in WildcardHelperTestCase fails: public void testEndPattern() throws Exception {

Re: [2.1.10] WildcardHelperTestCase fails

2006-12-05 Thread Alfred Nathaniel
On Tue, 2006-12-05 at 11:02 +0100, Carsten Ziegeler wrote: Afaik, the code for the wildcard helper has been replaced after that by someone else. Carsten Bertrand Delacretaz wrote: Just tried to run the junit tests on BRANCH_2_1_X, and the second assertion in WildcardHelperTestCase fails:

Re: [2.1.10] WildcardHelperTestCase fails

2006-12-05 Thread Bertrand Delacretaz
On 12/5/06, Alfred Nathaniel [EMAIL PROTECTED] wrote: ...Also there are two distinct copies of WildcardHelperTestCase in src/test/org/apache/cocoon/util/test and src/test/org/apache/cocoon/matching/helpers which both should go... You mean remove the test cases? I wouldn't do that unless the

Re: [2.1.10] WildcardHelperTestCase fails

2006-12-05 Thread Carsten Ziegeler
Bertrand Delacretaz wrote: On 12/5/06, Alfred Nathaniel [EMAIL PROTECTED] wrote: ...Also there are two distinct copies of WildcardHelperTestCase in src/test/org/apache/cocoon/util/test and src/test/org/apache/cocoon/matching/helpers which both should go... You mean remove the test cases?