Re: COCOON3-126, xslt cache

2013-07-06 Thread Jos Snellings
Hi Simo (et al), 1. I do not get the point defining the 'cache' interface. The simplest would be to allow a switch in the constructor: In that case, forget the injection: @Autowire private Settings settings; public XSLTTransformer(boolean enableLRUCache) public XSLTTransformer(final URL url,

Re: COCOON3-126, xslt cache

2013-07-02 Thread Simone Tripodi
Hi Jos, the most important thing is IMHO having the XSLT transformer dependencies-less as much as we can - I suggest to define a cache interface (with a basic implementation) provided to XSLT transformer (via constructor), then users are free to use whatever implementation they need/prefer.

Re: COCOON3-126, xslt cache

2013-07-02 Thread Jos Snellings
Yes, Simo, that is a good approach! I think it is worth the work in order to keep the cocoon base classes tidy. We can work out a proposal during the weekend, (though it will be very nice weather in Belgium). Cheers, Jos On Tue, Jul 2, 2013 at 11:38 AM, Simone Tripodi

Re: COCOON3-126, xslt cache

2013-07-02 Thread Simone Tripodi
We can work out a proposal during the weekend, (though it will be very nice weather in Belgium). we are having sunny days in Rome as well (finally!) so I'll do some work in the night on the terrace :) have a nice day, all the best! -Simo http://people.apache.org/~simonetripodi/

Re: COCOON3-126, xslt cache

2013-07-02 Thread Jos Snellings
Yet, as a Roman, you enjoy a different likelihood for sunny weather :-). Nonetheless, getting inspiration is very important! Jos On Tue, Jul 2, 2013 at 1:12 PM, Simone Tripodi simonetrip...@apache.orgwrote: We can work out a proposal during the weekend, (though it will be very nice