Joerg Heinicke wrote:
Vadim Gritsenko wrote:
David Crossley wrote:
The recent commit of all the *.license files proved that Eclipse
is the culprit. Until their Bug 15119 is fixed (please vote for it),
the Eclipse users should use the workaround to add the unknown
text types.
The
Le Mercredi, 3 mars 2004, à 11:16 Europe/Zurich, David Crossley a écrit
:
...I wonder if it is true that almost every committer uses Eclipse?
I use command-line cvs.
FWIW, I use IDEA, and often command-line CVS as well.
The transparency of the command-line makes me feel safer ;-)
-Bertrand
David Crossley wrote:
David Crossley wrote:
...
We have quite a number of these problem files in cocoon-2.1
I noticed a new one come in today with Carsten's commit
of portal.samplesxconf
The recent commit of all the *.license files proved that Eclipse
is the culprit. Until their Bug
On 02.03.2004 14:34, Vadim Gritsenko wrote:
We have quite a number of these problem files in cocoon-2.1
I noticed a new one come in today with Carsten's commit
of portal.samplesxconf
The recent commit of all the *.license files proved that Eclipse
is the culprit. Until their Bug 15119 is
David Crossley wrote:
Joerg Heinicke wrote:
Joerg Heinicke wrote:
I might be wrong but today I had the feeling that Eclipse just ignores
the default -kkv set in Eclipse itself and adds every file with unknown
file ending as binary. You maybe have to add your file endings at
On 17.02.2004 07:09, Bertrand Delacretaz wrote:
The -k option is only for 'add' and 'update' etc.
The default with the command-line client is to do ASCII and you
need to explicitly do 'cvs add -kb' for images, and jar files, etc
Note also that the binary -kb flag is set automatically when
On 17.02.2004 06:17, David Crossley wrote:
I have a big list of what should be a text file extension in the
binarytext.pl script. Perhaps we need to change our license files
to have a .txt filename extension.
What about ${lib}.legal instead of current legal.${lib}?
Thanks Joerg, for your
On 18.02.2004 02:32, Joerg Heinicke wrote:
I might be wrong but today I had the feeling that Eclipse just ignores
the default -kkv set in Eclipse itself and adds every file with unknown
file ending as binary. You maybe have to add your file endings at
Window Preferences Team File Content.
Le Mardi, 17 fév 2004, à 06:17 Europe/Zurich, David Crossley a écrit :
...
The -k option is only for 'add' and 'update' etc.
The default with the command-line client is to do ASCII and you
need to explicitly do 'cvs add -kb' for images, and jar files, etc
Note also that the binary -kb flag is
Antonio Gallardo wrote:
David Crossley dijo:
Perhaps the Ant project has a corrupted CVS like our was.
They might have dos line-endings in their ant.bat etc.
I thought .bat files must have line ending as DOS: 0x0D 0x0A
And Linux files must have just 0x0A
Is this correct?
No, not
David Crossley dijo:
Antonio Gallardo wrote:
David Crossley dijo:
Perhaps the Ant project has a corrupted CVS like our was.
They might have dos line-endings in their ant.bat etc.
I thought .bat files must have line ending as DOS: 0x0D 0x0A
And Linux files must have just 0x0A
Is this
Joerg Heinicke wrote:
Not a witch-hunt, but name the people. They must know it,
that something is broken. I for example use Eclipse and WinCVS.
I can at least imagine that a problematic constellation can be
using cvs from cygwin, so you have a mixture of Linux/Windows tools.
Yes, there are
David Crossley wrote:
tony
src/blocks/scratchpad/samples/othello/osml/core/layout.xsl
... recent one, still not fixed.
Thanks for the heads up. I'll check it out tomorrow when I'm at work.
Too many files to keep track of at once. :P
I will keep monitoring CVS to see if there are any others.
David Crossley wrote:
Unico Hommes wrote:
Wow that is a lot of files. Looks like basically all of them?
snip/
However, the command does not seem to work for you on cygwin.
All files probably do have ^M on your system.
There should be about 91 such files.
Perhaps this UNIX command does
To: [EMAIL PROTECTED]
Subject: Re: whitespace cleanup and efficiency drive
Okay, i now have the cocoon-2.2 CVS completely clean of any
dos2unix problems.
Now we are not going on a witch-hunt or anything, but ...
I have perceptions that there are some committers who use CVS
clients
Joerg Heinicke wrote:
David Crossley wrote:
Okay, i now have the cocoon-2.2 CVS completely clean of
any dos2unix problems.
Now we are not going on a witch-hunt or anything, but ...
Not a witch-hunt, but name the people. They must know it, that something
is broken. I for example
Unico Hommes wrote:
I noticed I sometimes have a problem with eclipse. I try to check my
commits since I noticed this problem. As far as webdav block is
concerned I am currently only working in davmap samples area so AFAIAC
no problem if you want to clean it up there.
But then, I just ran
Unico Hommes wrote:
I noticed I sometimes have a problem with eclipse. I try to check my
commits since I noticed this problem. As far as webdav block is
concerned I am currently only working in davmap samples area so AFAIAC
no problem if you want to clean it up there.
That is one of the
David Crossley wrote:
Unico Hommes wrote:
I noticed I sometimes have a problem with eclipse. I try to
check my
commits since I noticed this problem. As far as webdav block is
concerned I am currently only working in davmap samples
area so AFAIAC
no problem if you want to clean
Unico Hommes wrote:
David Crossley wrote:
Try running the command as shown at
http://cocoon.apache.org/community/committer.html
except add the -w option to grep.
:-( no luck. I remember reading something about the -w option for cygwin
but cannot find it now. I will look into it
Unico Hommes wrote:
David Crossley wrote:
Try running the command as shown at
http://cocoon.apache.org/community/committer.html
Are you running the last command on that page, and adding the
^M as shown?
Ah! I assumed that remark didn't apply when you copy/paste.
Wow
Okay, i now have the cocoon-2.2 CVS completely clean of
any dos2unix problems.
Now we are not going on a witch-hunt or anything, but ...
I have perceptions that there are some committers who use
CVS clients that don't handle the linefeed conversion properly.
It would be good to find those cases
Vadim Gritsenko wrote:
David Crossley wrote:
Joerg Heinicke wrote:
The result of this thread: let's care only about white spaces.
So now we need a policy. Here is my proposal:
For all text files
- Replace all tabs with spaces.
- No trailing whitespace.
- No M$-DOS line endings.
-
Joerg Heinicke wrote:
The result of this thread: let's care only about white spaces.
So now we need a policy. Here is my proposal:
For all text files
- Replace all tabs with spaces.
- No trailing whitespace.
- No M$-DOS line endings.
- Newline at end-of-file.
- Single whitespace between words.
Joerg Heinicke wrote:
The result of this thread: let's care only about white spaces.
It's my opinion too. But the editor should do this automatically, not by
running a task by hand.
Agreed. I am adding it to my requirements list, in the search for
a new editor.
IDEA does it pretty good:
IDEA does it pretty good: Removes trailing
spaces when saving a file, replaces existing tabs with spaces on save,
when using the key TAB it adds spaces to the file. But unfortunately
IDEA is not for free.
Ah, others keep mentioning IDEA too.
Hm... just wondering if they might give away a
Stefano Mazzocchi dijo:
I've started to evaluate IDEA as well because eclipse on mach-o is
simply not usable if you don't have several GBs of RAM (and I don't)
lol. We are using Eclipse and in fact I need to upgrade our 3 machines to
512, 768 and 1024 of RAM respectively. :-D
It looks like
Reinhard Poetz wrote:
From: Antonio Gallardo
Stefano Mazzocchi dijo:
I've started to evaluate IDEA as well because eclipse on mach-o is
simply not usable if you don't have several GBs of RAM (and I don't)
lol. We are using Eclipse and in fact I need to upgrade our 3
machines to
From: Vadim Gritsenko
Reinhard Poetz wrote:
From: Antonio Gallardo
Stefano Mazzocchi dijo:
I've started to evaluate IDEA as well because eclipse on mach-o is
simply not usable if you don't have several GBs of RAM
(and I don't)
lol. We are using Eclipse and in
Reinhard Poetz dijo:
From: Vadim Gritsenko
Reinhard Poetz wrote:
From: Antonio Gallardo
Stefano Mazzocchi dijo:
I've started to evaluate IDEA as well because eclipse on mach-o is
simply not usable if you don't have several GBs of RAM
(and I don't)
lol. We are using Eclipse
Le Lundi, 10 nov 2003, à 16:56 Europe/Zurich, David Crossley a écrit :
...
Well this is all that this discussion really set out to achieve:
consistent 4-space indentation, remove all tabs, get rid of other
spurious whitespace. So, yes, let us stop at that.
+1, keep it simple!
IIUC the whole
Bertrand Delacretaz wrote:
David Crossley a écrit :
...
Well this is all that this discussion really set out to achieve:
consistent 4-space indentation, remove all tabs, get rid of other
spurious whitespace. So, yes, let us stop at that.
+1, keep it simple!
IIUC the whole point is
Tony Collen wrote:
David Crossley wrote:
snip/
I suppose that it is a dream, but does anybody know about a
tool that would automatically apply say 4-space indentation
and whitespace clean up? We could apply that to our whole
cvs say once per month.
Jalopy?
David Crossley wrote:
Looks interesting and worth a try. Now we need one for xml too.
jEdit with the XSL-T plugin.
Ugo
--
Ugo Cei - Consorzio di Bioingegneria e Informatica Medica
P.le Volontari del Sangue, 2 - 27100 Pavia - Italy
Phone: +39.0382.525100 - E-mail: [EMAIL PROTECTED]
From: David Crossley
It might sound pedantic, but it is about efficiency.
I have wasted a lot of time during my committer life with
confusing patches that contain mainly whitespace changes. Not
to criticise the patcher or their tools, but today was a
classic. With some manual tweaks to
Hi Tony, team
Jalopy?
http://jalopy.sourceforge.net/
Never used it, just Google'd it.
I use Jalopy, it's very good, I can recommend it, you get a GUI to set you
layout preferences, if necessary you can automate it to run as an ANT task.
So yes it would be a way of enforcing consistent use
David Crossley wrote:
Tony Collen wrote:
David Crossley wrote:
snip/
I suppose that it is a dream, but does anybody know about a
tool that would automatically apply say 4-space indentation
and whitespace clean up? We could apply that to our whole
cvs say once per month.
Jalopy?
Butler, Mark wrote:
I use Jalopy, it's very good, I can recommend it, you get a GUI to set you
layout preferences, if necessary you can automate it to run as an ANT task.
So yes it would be a way of enforcing consistent use of whitespace
everywhere,
Great news Mark, thanks. I see that they
Giacomo Pati wrote:
David Crossley wrote:
snip/
That would be nice for us. Unfortunately, we probably have to take
whatever comes and fix it with clever tools before commit.
Be carful when doing precommit reformatting on the cvs server side
(which is doable with CVS). This might give you
Tony Collen wrote:
Perhaps we need a Guide to Not Letting Your Editor Mess Up The Code(tm).
This is the crux of the issue. We should not care how the
diffs or files come to us. Any old mess will suffice. As long
as we committers have tools to handle it. We apply the diff,
run the tool to
David Crossley wrote:
Giacomo Pati wrote:
David Crossley wrote:
snip/
That would be nice for us. Unfortunately, we probably have to take
whatever comes and fix it with clever tools before commit.
Be carful when doing precommit reformatting on the cvs server side
(which is doable with CVS).
David Crossley wrote:
I suppose that it is a dream, but does anybody know about a
tool that would automatically apply say 4-space indentation
and whitespace clean up? We could apply that to our whole
cvs say once per month.
If we agree on style, I can run IDEA on whole source tree
Vadim
From: Vadim Gritsenko
David Crossley wrote:
I suppose that it is a dream, but does anybody know about a
tool that
would automatically apply say 4-space indentation and
whitespace clean
up? We could apply that to our whole cvs say once per month.
If we agree on style, I can run
Vadim Gritsenko wrote:
If we agree on style, I can run IDEA on whole source tree
Yes, if we can just define the style then any of our tools
should be able to apply it.
Perhaps we could gradually develop our style. For example
start with only indentation and whitespace, get that sorted
for
On Mon, 11 Nov 2003, David Crossley wrote:
Perhaps we could gradually develop our style. For example
start with only indentation and whitespace, get that sorted
for both java and xml, then address another issue, and so on.
I thought our style was already defined, as like Sun?
Andrew.
--
Andrew Savory wrote:
On Mon, 11 Nov 2003, David Crossley wrote:
Perhaps we could gradually develop our style. For example
start with only indentation and whitespace, get that sorted
for both java and xml, then address another issue, and so on.
I thought our style was already defined, as like Sun?
Andrew Savory wrote:
David Crossley wrote:
Perhaps we could gradually develop our style. For example
start with only indentation and whitespace, get that sorted
for both java and xml, then address another issue, and so on.
I thought our style was already defined, as like Sun?
Yes, but
On 10 Nov 2003, at 14:06, David Crossley wrote:
Vadim Gritsenko wrote:
If we agree on style, I can run IDEA on whole source tree
Yes, if we can just define the style then any of our tools
should be able to apply it.
Perhaps we could gradually develop our style. For example
start with only
Stefano Mazzocchi wrote:
Stop!
history shows pretty evidently that you can't reach consensus on style,
unless your compiler is style dependant (which is why Python code all
looks the same!).
tab is bad. everytime you see tabs you should change them into 4
whitespaces. this is the
On Mon, 2003-11-10 at 06:16, Tony Collen wrote:
snip/
Jalopy?
http://jalopy.sourceforge.net/
We are using jalopy to format bean classes generated from OJB mapping
files. It works like a charm.
+1
(2 cents worth)
Regards,
Per-Olof Norén
It might sound pedantic, but it is about efficiency.
I have wasted a lot of time during my committer life with
confusing patches that contain mainly whitespace changes.
Not to criticise the patcher or their tools, but today
was a classic. With some manual tweaks to whitespace,
i managed to bring
David Crossley wrote:
It might sound pedantic, but it is about efficiency.
I have wasted a lot of time during my committer life with
confusing patches that contain mainly whitespace changes.
Not to criticise the patcher or their tools, but today
was a classic. With some manual tweaks to
52 matches
Mail list logo
