Re: Submitting patches in JIRA

2006-11-13 Thread Mark Lundquist
On Nov 12, 2006, at 9:13 PM, David Crossley wrote: Use the Edit this issue link on the left-hand panel when you are viewing an issue. It's not there for me. I have Attach File, Attach Screenshot, Clone, Comment, Create sub-task, Voting, and Watching. —ml—

Re: svn commit: r473974 - in /cocoon/trunk/blocks: cocoon-ajax/cocoon-ajax-impl/src/main/resources/org/apache/cocoon/ajax/resources/js/ cocoon-forms/cocoon-forms-impl/src/main/resources/org/apache/coc

2006-11-13 Thread Jeremy Quinn
On 12 Nov 2006, at 23:41, Antonio Gallardo wrote: Hi Jeremy, Nice work. Please look into the small issues below: snip/ We use 4 spaces for tabs. Ugh! I hate the 4 spaces rule ;) Encoding typo? Please review your subversion settings. I think it was a UTF-8 Byte Order Mark, removed

Re: svn commit: r473974 - in /cocoon/trunk/blocks: cocoon-ajax/cocoon-ajax-impl/src/main/resources/org/apache/cocoon/ajax/resources/js/ cocoon-forms/cocoon-forms-impl/src/main/resources/org/apache/coc

2006-11-13 Thread Antonio Gallardo
Jeremy Quinn escribió: On 12 Nov 2006, at 23:41, Antonio Gallardo wrote: Hi Jeremy, Nice work. Please look into the small issues below: snip/ We use 4 spaces for tabs. Ugh! I hate the 4 spaces rule ;) Encoding typo? Please review your subversion settings. I think it was a UTF-8

Re: call a function not in global object in map:call

2006-11-13 Thread Rice Yeh
Thank you. Will this patch go into the trunk eventually?RiceOn 11/13/06, Mark Lundquist [EMAIL PROTECTED] wrote:On Nov 12, 2006, at 1:31 AM, I wrote: [...snip] Here's a patch you can try.[...snip] Do'h. my bad!I didn't realize when I sent you that diff that I was inthe middle of changing the code

Re: Submitting patches in JIRA

2006-11-13 Thread David Crossley
Mark Lundquist wrote: David Crossley wrote: Use the Edit this issue link on the left-hand panel when you are viewing an issue. It's not there for me. I have Attach File, Attach Screenshot, Clone, Comment, Create sub-task, Voting, and Watching. Ah, i see what is happening. Only people

Re: Submitting patches in JIRA

2006-11-13 Thread Bertrand Delacretaz
On 11/14/06, David Crossley [EMAIL PROTECTED] wrote: ...Some other projects also enable jira-users to Edit, i.e. change Summary, Description, Components, Fix Version, etc. So, Cocoon PMC, should we loosen the permissions for Edit?.. +1, this is useful. -Bertrand