[GUMP@vmgump]: Project commons-configuration-test (in module apache-commons) failed

2012-03-15 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-configuration-test has an issue affecting its community

[GUMP@vmgump]: Project commons-proxy-test (in module apache-commons) failed

2012-03-15 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-proxy-test has an issue affecting its community integration. This

[GUMP@vmgump]: Project commons-id (in module commons-sandbox) failed

2012-03-15 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-id has an issue affecting its community integration. This issue

[GUMP@vmgump]: Project commons-vfs2-test (in module apache-commons) failed

2012-03-15 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-vfs2-test has an issue affecting its community integration. This

Re: [csv] Headers

2012-03-15 Thread Benedikt Ritter
Am 15. März 2012 01:58 schrieb Emmanuel Bourg ebo...@apache.org: There is another alternative, we might replace the records returned as a String[] by a CSVRecord class able to access the fields by id or by name. This would be similar to a JDBC resultset (except for the looping logic) sounds

Re: [csv] Headers

2012-03-15 Thread Emmanuel Bourg
Le 15/03/2012 08:55, Benedikt Ritter a écrit : I'm not sure if I understand the approach completely. The Header can not be accessed as a CSVRecord, right? CSVRecords know the header values through get(string). What happens if the format does not support a header? UnsupportedOperationException?

[continuum] BUILD FAILURE: Apache Commons - Apache Commons Digester - Default Maven 2 Build Definition (Java 1.5)

2012-03-15 Thread Continuum@vmbuild
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=20142projectId=75 Build statistics: State: Failed Previous State: Failed Started at: Thu 15 Mar 2012 10:20:10 + Finished at: Thu 15 Mar 2012 10:21:20 + Total time: 1m 10s Build Trigger: Schedule

[continuum] BUILD FAILURE: Apache Commons - Apache Commons Digester - Default Maven 2 Build Definition (Java 1.5)

2012-03-15 Thread Continuum@vmbuild
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=20144projectId=75 Build statistics: State: Failed Previous State: Failed Started at: Thu 15 Mar 2012 11:20:09 + Finished at: Thu 15 Mar 2012 11:21:19 + Total time: 1m 9s Build Trigger: Schedule

Re: svn commit: r1300925 - /commons/sandbox/beanutils2/trunk/src/main/java/org/apache/commons/beanutils2/AccessibleObjectsRegistry.java

2012-03-15 Thread sebb
On 15 March 2012 11:26, simonetrip...@apache.org wrote: Author: simonetripodi Date: Thu Mar 15 11:26:25 2012 New Revision: 1300925 URL: http://svn.apache.org/viewvc?rev=1300925view=rev Log: just incrementally built the hashcode in the constructor I wondered why you did not use the

Re: svn commit: r1300925 - /commons/sandbox/beanutils2/trunk/src/main/java/org/apache/commons/beanutils2/AccessibleObjectsRegistry.java

2012-03-15 Thread Benedikt Ritter
Am 15. März 2012 12:59 schrieb sebb seb...@gmail.com: On 15 March 2012 11:26,  simonetrip...@apache.org wrote: Author: simonetripodi Date: Thu Mar 15 11:26:25 2012 New Revision: 1300925 URL: http://svn.apache.org/viewvc?rev=1300925view=rev Log: just incrementally built the hashcode in the

[CSV] Performance

2012-03-15 Thread sebb
In my testing, using final class variables for delimiter, escape etc (set in ctor) shaves about 1 sec off the time to read the world town data file compared with accessing these fields inline through the format field. Average time goes from c. 25.5 to c. 24.5 which is a 4% improvement. I suspect

Re: [CSV] Performance

2012-03-15 Thread Emmanuel Bourg
Le 15/03/2012 13:34, sebb a écrit : In my testing, using final class variables for delimiter, escape etc (set in ctor) shaves about 1 sec off the time to read the world town data file compared with accessing these fields inline through the format field. Average time goes from c. 25.5 to c. 24.5

Re: [CSV] Performance

2012-03-15 Thread Benedikt Ritter
Am 15. März 2012 13:50 schrieb Gary Gregory garydgreg...@gmail.com: Can you put your perf test code and resources in SVN so I do not have to write on please? Hi Gary, have a look at http://markmail.org/message/x73i3hl63rjqdyfa (I agree with you, that having a clean performance test in SVN

Re: [CSV] Performance

2012-03-15 Thread sebb
On 15 March 2012 12:43, Emmanuel Bourg ebo...@apache.org wrote: Le 15/03/2012 13:34, sebb a écrit : In my testing, using final class variables for delimiter, escape etc (set in ctor) shaves about 1 sec off the time to read the world town data file compared with accessing these fields inline

Re: [CSV] Performance

2012-03-15 Thread Emmanuel Bourg
Le 15/03/2012 14:13, sebb a écrit : Eclipse, so probably client VM? Probably. You can print the java.vm.name system property at the beginning of the test, that will tell you the VM used. Emmanuel Bourg smime.p7s Description: S/MIME Cryptographic Signature

Re: svn commit: r1300977 - in /commons/proper/csv/trunk: ./ src/test/java/org/apache/commons/csv/

2012-03-15 Thread Benedikt Ritter
Am 15. März 2012 14:44 schrieb ggreg...@apache.org: Author: ggregory Date: Thu Mar 15 13:44:44 2012 New Revision: 1300977 URL: http://svn.apache.org/viewvc?rev=1300977view=rev Log: Update to JUnit 4.10 from 3.8.1. nice work! how about a static import of org.junit.Assert.* ? Modified:  

Re: svn commit: r1300977 - in /commons/proper/csv/trunk: ./ src/test/java/org/apache/commons/csv/

2012-03-15 Thread Emmanuel Bourg
Aaargh not now, it conflicts with my pending changes :( Le 15/03/2012 14:44, ggreg...@apache.org a écrit : Author: ggregory Date: Thu Mar 15 13:44:44 2012 New Revision: 1300977 URL: http://svn.apache.org/viewvc?rev=1300977view=rev Log: Update to JUnit 4.10 from 3.8.1. Modified:

Re: svn commit: r1300977 - in /commons/proper/csv/trunk: ./ src/test/java/org/apache/commons/csv/

2012-03-15 Thread Gary Gregory
On Thu, Mar 15, 2012 at 9:49 AM, Emmanuel Bourg ebo...@apache.org wrote: Aaargh not now, it conflicts with my pending changes :( Zut alors! How was I to know :( G Le 15/03/2012 14:44, ggreg...@apache.org a écrit : Author: ggregory Date: Thu Mar 15 13:44:44 2012 New Revision: 1300977

Re: svn commit: r1300977 - in /commons/proper/csv/trunk: ./ src/test/java/org/apache/commons/csv/

2012-03-15 Thread Emmanuel Bourg
Le 15/03/2012 14:59, Gary Gregory a écrit : Zut alors! How was I to know :( By asking the list first I guess :) Could you just add the static import please? This will reduce the conflicts. Emmanuel Bourg smime.p7s Description: S/MIME Cryptographic Signature

[GUMP@vmgump]: Project commons-exec-test (in module apache-commons) failed

2012-03-15 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-exec-test has an issue affecting its community integration. This

Re: svn commit: r1300977 - in /commons/proper/csv/trunk: ./ src/test/java/org/apache/commons/csv/

2012-03-15 Thread Emmanuel Bourg
Le 15/03/2012 15:39, Gary Gregory a écrit : Yuck! I like to see the receiver of the message I am sending. The only time I can see SI being justified to in math expressions (X * Y + 1 type of stuff) I agree, but that depends on the context. In a unit test it's not really ambiguous. I'll

Re: [CSV] Performance

2012-03-15 Thread Ted Dunning
I built a limited CSV package for parsing data in Mahout at one point. I doubt that it was general enough to be helpful here, but the experience might be. The thing that *really* made a big difference in speed was to avoid copies and conversions to String. To do that, I built a state machine

Re: [CSV] Performance

2012-03-15 Thread Emmanuel Bourg
Thank you for sharing your experience Ted. Do you have a link to the code of your parser? I'd like to get a look. Currently the data flow in Commons CSV is: 1. Buffer the data in the BufferedReader 2. Accumulate data in a reusable buffer for the current token 3. Turn the token buffer into a

[continuum] BUILD FAILURE: Apache Commons - Apache Commons Digester - Default Maven 2 Build Definition (Java 1.5)

2012-03-15 Thread Continuum@vmbuild
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=20150projectId=75 Build statistics: State: Failed Previous State: Failed Started at: Thu 15 Mar 2012 15:20:10 + Finished at: Thu 15 Mar 2012 15:21:11 + Total time: 1m 1s Build Trigger: Schedule

Re: [CSV] Performance

2012-03-15 Thread sebb
On 15 March 2012 13:17, Emmanuel Bourg ebo...@apache.org wrote: Le 15/03/2012 14:13, sebb a écrit : Eclipse, so probably client VM? Probably. You can print the java.vm.name system property at the beginning of the test, that will tell you the VM used. It was client. I've now tried with

Re: [CSV] Performance

2012-03-15 Thread Emmanuel Bourg
Le 15/03/2012 16:45, sebb a écrit : So I then tried hauling the format method calls out of the loops into final local variables. This improves performance (slightly) in both client and server mode. Could you show some code please? I'm unable to reproduce this. I used local variables in

Re: [CSV] Performance

2012-03-15 Thread sebb
On 15 March 2012 16:10, Emmanuel Bourg ebo...@apache.org wrote: Le 15/03/2012 16:45, sebb a écrit : So I then tried hauling the format method calls out of the loops into final local variables. This improves performance (slightly) in both client and server mode. Could you show some code

Re: [CSV] Performance

2012-03-15 Thread Emmanuel Bourg
Le 15/03/2012 17:42, sebb a écrit : I also used local vars in the other methods. See http://people.apache.org/~sebb/CSV/ Thank you. You also reordered the if in simpleTokenLexer, that may explain the difference. I'll give it a try. Emmanuel Bourg smime.p7s Description: S/MIME

Re: [CSV] Performance

2012-03-15 Thread sebb
On 15 March 2012 16:48, Emmanuel Bourg ebo...@apache.org wrote: Le 15/03/2012 17:42, sebb a écrit : I also used local vars in the other methods. See http://people.apache.org/~sebb/CSV/ Thank you. You also reordered the if in simpleTokenLexer, that may explain the difference. I'll give it

Re: [CSV] Performance

2012-03-15 Thread Emmanuel Bourg
Le 15/03/2012 18:06, sebb a écrit : If I revert it, I still get a better time with Lexer2, though not quite as good an improvement. I ran my perf test, Lexer2 is slower on my system :( The order of the if doesn't change much here. Emmanuel Bourg smime.p7s Description: S/MIME

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-15 Thread Benedikt Ritter
Am 14. März 2012 22:47 schrieb sebb seb...@gmail.com: On 14 March 2012 21:40, Benedikt Ritter benerit...@googlemail.com wrote: Am 14. März 2012 22:33 schrieb Emmanuel Bourg ebo...@apache.org: Le 14/03/2012 22:25, Benedikt Ritter a écrit : I agree with you on this. However, I think it would

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-15 Thread Emmanuel Bourg
Le 15/03/2012 20:26, Benedikt Ritter a écrit : How about you Emmanuel? Could sebb convince you? ;-) How about this: I'll create a patch and attach it to JIRA. Then we'll have a better basis for discussion. Sorry but I'm not convinced. I see exactly where this leads. If you have some free

[continuum] BUILD FAILURE: Apache Commons - Apache Commons Digester - Default Maven 2 Build Definition (Java 1.5)

2012-03-15 Thread Continuum@vmbuild
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=20159projectId=75 Build statistics: State: Failed Previous State: Failed Started at: Thu 15 Mar 2012 20:20:11 + Finished at: Thu 15 Mar 2012 20:21:37 + Total time: 1m 25s Build Trigger: Schedule

Re: svn commit: r1301220 - /commons/sandbox/graph/trunk/src/main/java/org/apache/commons/graph/export/

2012-03-15 Thread Simone Tripodi
Hi Thomas! can I kindly ask you please to help me on merging modifications on /trunk to the experimental branch? I completed the drop the markers work but I still need to complete the exporters... Hope you can help, thanks in advance! -Simo http://people.apache.org/~simonetripodi/

Re: svn commit: r1301220 - /commons/sandbox/graph/trunk/src/main/java/org/apache/commons/graph/export/

2012-03-15 Thread Thomas Neidhart
On 03/15/2012 10:50 PM, Simone Tripodi wrote: Hi Thomas! can I kindly ask you please to help me on merging modifications on /trunk to the experimental branch? I completed the drop the markers work but I still need to complete the exporters... Hope you can help, thanks in advance! Hi

Re: svn commit: r1301220 - /commons/sandbox/graph/trunk/src/main/java/org/apache/commons/graph/export/

2012-03-15 Thread Simone Tripodi
thanks a lot in advance, very appreciated! -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Thu, Mar 15, 2012 at 10:56 PM, Thomas Neidhart thomas.neidh...@gmail.com wrote: On 03/15/2012 10:50 PM,

[continuum] BUILD FAILURE: Apache Commons - Apache Commons Digester - Default Maven 2 Build Definition (Java 1.5)

2012-03-15 Thread Continuum@vmbuild
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=20163projectId=75 Build statistics: State: Failed Previous State: Failed Started at: Thu 15 Mar 2012 22:20:09 + Finished at: Thu 15 Mar 2012 22:21:26 + Total time: 1m 17s Build Trigger: Schedule

Re: svn commit: r1301177 - /commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/binder/AbstractRulesModule.java

2012-03-15 Thread sebb
On 15 March 2012 20:09, simonetrip...@apache.org wrote: Author: simonetripodi Date: Thu Mar 15 20:09:31 2012 New Revision: 1301177 URL: http://svn.apache.org/viewvc?rev=1301177view=rev Log: potential fix for [DIGESTER-163] If the problem is due to multi-threading issues, isn't that

[continuum] BUILD ERROR: Apache Commons - Commons Net - Default Maven 2 Build Definition (Java 1.5)

2012-03-15 Thread Continuum@vmbuild
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=20166projectId=107 Build statistics: State: Error Previous State: Ok Started at: Fri 16 Mar 2012 00:21:16 + Finished at: Fri 16 Mar 2012 00:21:18 + Total time: 1s Build Trigger: Schedule Build

[GUMP@vmgump]: Project commons-digester3 (in module apache-commons) failed

2012-03-15 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-digester3 has an issue affecting its community integration. This

[GUMP@vmgump]: Project commons-collections4-testframework (in module apache-commons) failed

2012-03-15 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-collections4-testframework has an issue affecting its community

[GUMP@vmgump]: Project commons-scxml-test (in module apache-commons) failed

2012-03-15 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-scxml-test has an issue affecting its community integration. This

[VOTE] Release Commons IO 2.2-RC1

2012-03-15 Thread Gary Gregory
Hello All: This is a VOTE to release Commons IO 2.2-RC1 This VOTE is open for at least 72 hours until March 19 2012 at 01:30 EST. The files: https://repository.apache.org/content/repositories/orgapachecommons-080/ The tag: https://svn.apache.org/repos/asf/commons/proper/io/tags/2.2-RC1 The

[GUMP@vmgump]: Project commons-configuration-test (in module apache-commons) failed

2012-03-15 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-configuration-test has an issue affecting its community