Re: [VOTE] Release Compress 1.6 based on RC3

2013-10-23 Thread Torsten Curdt
+1 let's release it! On Wed, Oct 23, 2013 at 6:56 AM, Stefan Bodewig bode...@apache.org wrote: Compress 1.6 RC3 is available for review here: https://dist.apache.org/repos/dist/dev/commons/compress/ (svn revision 3327) Maven artifacts are here:

Re: [VOTE] Release Compress 1.6 based on RC3

2013-10-23 Thread Emmanuel Bourg
+1 The test coverage is much better, thank you Stefan. test7zDecryptUnarchive failed on Linux using the Java 6 JDK (not OpenJDK6) due to the lack of the strong crypto policy. That's easily fixed by installing the missing files [1], but as a convenience I would suggest skipping this test when the

[compress] Strong Crypto in Tests

2013-10-23 Thread Stefan Bodewig
On 2013-10-23, Emmanuel Bourg wrote: The test coverage is much better, thank you Stefan. Thank you for making me find a serious bug by pointing out the low coverage :-) test7zDecryptUnarchive failed on Linux using the Java 6 JDK (not OpenJDK6) due to the lack of the strong crypto policy.

Re: [compress] Strong Crypto in Tests

2013-10-23 Thread Jörg Schaible
Stefan Bodewig wrote: On 2013-10-23, Emmanuel Bourg wrote: The test coverage is much better, thank you Stefan. Thank you for making me find a serious bug by pointing out the low coverage :-) test7zDecryptUnarchive failed on Linux using the Java 6 JDK (not OpenJDK6) due to the lack of

Re: [compress] Strong Crypto in Tests

2013-10-23 Thread Stefan Bodewig
On 2013-10-23, Jörg Schaible wrote: boolean supportedKeyLength(int keyLen) throws NoSuchAlgorithmException { if (Cipher.getMaxAllowedKeyLength(AES/ECB/PKCS5Padding) keyLen) { System.err.println(WARNING: + getName() + not executed, environment does not support + keyLen

[MATH] Repurposing a deprecated constructor in EigenDecomposition

2013-10-23 Thread Sean Owen
In MATH-1045 (https://issues.apache.org/jira/browse/MATH-1045) we have discussed adding a zero threshold tolerance to EigenDecomposition just like QRDecomposition has. This involves adding a new constructor with a new double parameter. Just one problem: there's already such a constructor:

Re: Commons functor

2013-10-23 Thread Bruno P. Kinoshita
Hi Mats! Hi, are there any plans for releasing this project? Yes, I'm already using [functor] in some experiments with fuzzy logic and Jenkins plug-ins, and having fun with JDK 8 lambdas. We still have two open issues before a release though. The Function I need is a PredicatedProcedure ie

Re: [compress] Strong Crypto in Tests

2013-10-23 Thread Bear Giles
Should that be PKCS7Padding? Or would that be worse - I don't recall if it's one of the must have paddings in the spec. http://crypto.stackexchange.com/questions/9043/what-is-the-difference-between-pkcs5-padding-and-pkcs7-padding In practice it's unlikely that a software-based crypto provider

Re: [compress] Strong Crypto in Tests

2013-10-23 Thread Stefan Bodewig
On 2013-10-23, Bear Giles wrote: Should that be PKCS7Padding? Or would that be worse - I don't recall if it's one of the must have paddings in the spec. 7z uses AES/CBC/NoPadding and that's what I use during the check inside the unit tests as well now. Stefan

Re: [MATH] Repurposing a deprecated constructor in EigenDecomposition

2013-10-23 Thread Sean Owen
Yeah it's a tricky one. I agree with the functionality, because the QR decomposition can happily operate on a singular matrix. R will be singular if A is, AFAIK. So the singularity threshold business belongs more in the bit that uses R, yes. The same could be said of the SVD. But it provides no

Re: [compress] Strong Crypto in Tests

2013-10-23 Thread Paul Benedict
In my own research on strong crypto, I found out that US law allows strong crypto to be exported for open source software. That was some provision recently carved out in the last 10 years. I think there are some limitations and procedures wrapped around it -- like submitting the URL to the source

Re: [lang] ImmutablePair is final

2013-10-23 Thread Gary Gregory
On Wed, Oct 23, 2013 at 9:09 AM, Paul Benedict pbened...@apache.org wrote: The safest approach is composition. It's the only way for the immutability contract to be honored across development teams (Commons + end user). Thank you all for your feedback. Gary On Wed, Oct 23, 2013 at 1:00

Re: [compress] Strong Crypto in Tests

2013-10-23 Thread Mark Fortner
As you're probably aware, aes is export restricted. So it might be better to simply check for the availability of a particular encryption algorithm before running a test and avoid making restricted libraries generally available. Mark On Oct 23, 2013 6:10 AM, Stefan Bodewig bode...@apache.org

Re: [compress] Strong Crypto in Tests

2013-10-23 Thread Stefan Bodewig
On 2013-10-23, Paul Benedict wrote: In my own research on strong crypto, I found out that US law allows strong crypto to be exported for open source software. That was some provision recently carved out in the last 10 years. I think there are some limitations and procedures wrapped around it

Re: [compress] Strong Crypto in Tests

2013-10-23 Thread Gary Gregory
Consider using JUnit's Assume to skip testing, this will allow IDEs and tools to know a test has been skipped. If you use a conditional in the test code, there is no possible feedback. Gary On Wed, Oct 23, 2013 at 5:15 AM, Stefan Bodewig bode...@apache.org wrote: On 2013-10-23, Emmanuel

Re: [compress] Strong Crypto in Tests

2013-10-23 Thread Stefan Bodewig
On 2013-10-23, Gary Gregory wrote: Consider using JUnit's Assume to skip testing, this will allow IDEs and tools to know a test has been skipped. Unfortunately the test like many of Compress' tests is in JUnit 3.x land - something to change if we ever get 2.x off the ground. Stefan

Re: [compress] Strong Crypto in Tests

2013-10-23 Thread Stefan Bodewig
On 2013-10-23, Mark Fortner wrote: As you're probably aware, aes is export restricted. Commons Compress already has a crypto notice, see also http://www.apache.org/licenses/exports/ 7z uses 256bit AES when encrypting so if we want to provide code that can read encrypted archives there is

Re: [MATH] Repurposing a deprecated constructor in EigenDecomposition

2013-10-23 Thread Ted Dunning
On Wed, Oct 23, 2013 at 3:14 PM, Sean Owen sro...@gmail.com wrote: EigenDecomposition resembles QR in this respect, as far as they are implemented here. This argues for them to treat arguments similarly. Actually not. It is quite reasonable for the EigenDecomposition to stop when singularity

Re: [maven build] Jira report?

2013-10-23 Thread Henri Yandell
On Tue, Oct 22, 2013 at 12:04 PM, Benedikt Ritter brit...@apache.orgwrote: 2013/10/22 sebb seb...@gmail.com On 22 October 2013 19:40, Henri Yandell flame...@gmail.com wrote: Anyone know what the point of the JIRA report is? It seems to be much like the changes report, but with less

Re: [maven build] Jira report?

2013-10-23 Thread Gary Gregory
One of the problems I have is that we do not solve is the following story well, and it is not a particular problem of Commons or the ASF: I want to update from [foo] version 2 to the current version 5. How do I know what's changed and what I need to do to migrate/upgrade? The first thing I do is

[lang] clirr violations

2013-10-23 Thread Gary Gregory
The current Clirr report shows errors. Do want to go to a 4.0 or fix the BC break and do a 3.2? Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Editionhttp://www.manning.com/bauer3/ JUnit in Action, Second Edition

Re: [maven build] Jira report?

2013-10-23 Thread Henri Yandell
Can you point me to a good JIRA report? The Lang one is worthless, so maybe the issue is that I don't understand what good would be :) On Wed, Oct 23, 2013 at 10:15 AM, Gary Gregory garydgreg...@gmail.comwrote: One of the problems I have is that we do not solve is the following story well,

Re: [maven build] Jira report?

2013-10-23 Thread Matt Benson
On Wed, Oct 23, 2013 at 12:15 PM, Gary Gregory garydgreg...@gmail.comwrote: One of the problems I have is that we do not solve is the following story well, and it is not a particular problem of Commons or the ASF: I want to update from [foo] version 2 to the current version 5. How do I know

Re: [lang] clirr violations

2013-10-23 Thread Henri Yandell
Check http://issues.apache.org/jira/browse/LANG-462 comments for the justification of the BC not being an issue. Hen On Wed, Oct 23, 2013 at 10:24 AM, Gary Gregory garydgreg...@gmail.comwrote: The current Clirr report shows errors. Do want to go to a 4.0 or fix the BC break and do a 3.2?

Re: svn commit: r1534380 - in /commons/proper/lang/trunk/src: main/java/org/apache/commons/lang3/NotImplementedException.java test/java/org/apache/commons/lang3/NotImplementedExceptionTest.java

2013-10-23 Thread Henri Yandell
On Tue, Oct 22, 2013 at 12:26 PM, Benedikt Ritter brit...@apache.orgwrote: Hi Hen, 2013/10/21 bay...@apache.org + * @author Apache Software Foundation This author tag looks strange. Did you add it by purpose? Removed :) Thanks for the catch; it was something we used to do in Commons

Re: [maven build] Jira report?

2013-10-23 Thread Gary Gregory
Original message From: Matt Benson Date:10/23/2013 13:45 (GMT-05:00) To: Commons Developers List Subject: Re: [maven build] Jira report? On Wed, Oct 23, 2013 at 12:15 PM, Gary Gregory garydgreg...@gmail.comwrote: One of the problems I have is that we do not solve is the

Re: [MATH] Repurposing a deprecated constructor in EigenDecomposition

2013-10-23 Thread Sean Owen
Ah I see so you can just stop computing the eigenvectors when the eigenvalues are too small. That does seem more efficient and then the zero values are left as literally 0. I think I should back up and implement the patch that way. The original question stands then -- what to do about the

[functor] Add functor to svngit2jira

2013-10-23 Thread Bruno P. Kinoshita
Hi,  Would it be all right to ask for [functor] component to be included in svngit2jira [1]? I've manually added commit messages to JIRA issues, but I believe this could be automated (thanks @Humbedooh). If there are no objections, I will file an issue during the weekend. Thanks! [1] 

Re: [VOTE] Release Compress 1.6 based on RC3

2013-10-23 Thread Gary Gregory
+1 Checked out the tag and built mvn site with: Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17 11:22:22-0400) Maven home: C:\Java\apache-maven-3.1.1\bin\.. Java version: 1.7.0_45, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.7.0_45\jre Default

Re: [imaging] got anything left to add before release?

2013-10-23 Thread Gary Gregory
I could see updating to Java 6 and using Charset objects instead of String encoding names to avoid catching exceptions in a bunch of places. That make the code a little cleaner. Gary On Wed, Oct 23, 2013 at 6:12 PM, Gary Gregory garydgreg...@gmail.comwrote: I think a nice way to proceed would

[imaging] Closing stream

2013-10-23 Thread Gary Gregory
Hi All: I see a log of this pattern: try { if (outputStream != null) { outputStream.close(); } } catch (final Exception e) { Debug.debug(e); } for example in

Re: [lang] clirr violations

2013-10-23 Thread Gary Gregory
On Wed, Oct 23, 2013 at 1:59 PM, Henri Yandell flame...@gmail.com wrote: Check http://issues.apache.org/jira/browse/LANG-462 comments for the justification of the BC not being an issue. Great, thank you for the pointer. Too bad we cannot annotate the Clirr report with custom comments, or

Re: [maven build] Jira report?

2013-10-23 Thread sebb
On 23 October 2013 18:15, Gary Gregory garydgreg...@gmail.com wrote: One of the problems I have is that we do not solve is the following story well, and it is not a particular problem of Commons or the ASF: I want to update from [foo] version 2 to the current version 5. How do I know what's

Re: [maven build] Jira report?

2013-10-23 Thread Gary Gregory
On Wed, Oct 23, 2013 at 9:33 PM, sebb seb...@gmail.com wrote: On 23 October 2013 18:15, Gary Gregory garydgreg...@gmail.com wrote: One of the problems I have is that we do not solve is the following story well, and it is not a particular problem of Commons or the ASF: I want to update from

Re: [imaging] Closing stream

2013-10-23 Thread sebb
On 24 October 2013 01:16, Gary Gregory garydgreg...@gmail.com wrote: Hi All: I see a log of this pattern: try { if (outputStream != null) { outputStream.close(); } } catch (final Exception e) {

Re: [imaging] Closing stream

2013-10-23 Thread Gary Gregory
On Wed, Oct 23, 2013 at 9:38 PM, sebb seb...@gmail.com wrote: On 24 October 2013 01:16, Gary Gregory garydgreg...@gmail.com wrote: Hi All: I see a log of this pattern: try { if (outputStream != null) { outputStream.close();

Re: [imaging] Closing stream

2013-10-23 Thread sebb
On 24 October 2013 02:49, Gary Gregory garydgreg...@gmail.com wrote: On Wed, Oct 23, 2013 at 9:38 PM, sebb seb...@gmail.com wrote: On 24 October 2013 01:16, Gary Gregory garydgreg...@gmail.com wrote: Hi All: I see a log of this pattern: try { if

Re: BCEL 6 release?

2013-10-23 Thread sebb
On 23 October 2013 23:10, Gary Gregory garydgreg...@gmail.com wrote: I wish we could just keep each version on the site... We can; several components have multiple Javadoc directories. Also there is no reason why the website should not reflect the released version, rather than current trunk.

Re: BCEL 6 release?

2013-10-23 Thread Gary Gregory
On Wed, Oct 23, 2013 at 10:12 PM, sebb seb...@gmail.com wrote: On 23 October 2013 23:10, Gary Gregory garydgreg...@gmail.com wrote: I wish we could just keep each version on the site... We can; several components have multiple Javadoc directories. Also there is no reason why the website

Re: BCEL 6 release?

2013-10-23 Thread sebb
On 24 October 2013 03:25, Gary Gregory garydgreg...@gmail.com wrote: On Wed, Oct 23, 2013 at 10:12 PM, sebb seb...@gmail.com wrote: On 23 October 2013 23:10, Gary Gregory garydgreg...@gmail.com wrote: I wish we could just keep each version on the site... We can; several components have

Re: [imaging] Closing stream

2013-10-23 Thread Bernd Eckenfels
Am 24.10.2013, 02:16 Uhr, schrieb Gary Gregory garydgreg...@gmail.com: try { if (outputStream != null) { outputStream.close(); } } catch (final Exception e) { Debug.debug(e); } this calls

Re: [MATH] Repurposing a deprecated constructor in EigenDecomposition

2013-10-23 Thread Ted Dunning
On Wed, Oct 23, 2013 at 8:33 PM, Sean Owen sro...@gmail.com wrote: it feels a little funny just because then we should have similar logic for other decompositions. I think I remember the LU one stops early, always. The stopping early is definitely an option with QR. With LU, it isn't so

Re: [imaging] Closing stream

2013-10-23 Thread Damjan Jovanovic
On Thu, Oct 24, 2013 at 4:34 AM, Bernd Eckenfels e...@zusammenkunft.net wrote: Am 24.10.2013, 02:16 Uhr, schrieb Gary Gregory garydgreg...@gmail.com: try { if (outputStream != null) { outputStream.close(); } } catch

Re: [imaging] got anything left to add before release?

2013-10-23 Thread Benedikt Ritter
+1 for Java 6 Send from my mobile device Am 24.10.2013 um 01:28 schrieb Gary Gregory garydgreg...@gmail.com: I could see updating to Java 6 and using Charset objects instead of String encoding names to avoid catching exceptions in a bunch of places. That make the code a little cleaner.

Re: [compress] Strong Crypto in Tests

2013-10-23 Thread Gary Gregory
On Thu, Oct 24, 2013 at 1:45 AM, Benedikt Ritter benerit...@gmail.comwrote: Send from my mobile device Am 23.10.2013 um 16:12 schrieb Stefan Bodewig bode...@apache.org: On 2013-10-23, Gary Gregory wrote: Consider using JUnit's Assume to skip testing, this will allow IDEs and tools