[GitHub] commons-compress pull request: Pkware headers

Github user bodewig commented on the pull request: https://github.com/apache/commons-compress/pull/5#issuecomment-164276454 Thanks I've merged you patch have a few questions - and would like to see tests :-) Not sure whether you'd prefer to discuss this here, inside a new PR

[GitHub] commons-compress pull request: Pkware headers

Github user asfgit closed the pull request at: https://github.com/apache/commons-compress/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[COMPRESS] PKWare header questions

1. I created the PKWareExtraHeader as a marker - it should make it clear that the headers will only be present in PKWare-created files and everyone else can ignore them. This is in contract to other headers that are much more standard. It was an oversight if this got lost when I had to refork the

Re: [COMPRESS] PKWare header questions

On 2015-12-13, Bear Giles wrote: > 1. I created the PKWareExtraHeader as a marker - it should make it clear > that the headers will only be present in PKWare-created files and everyone > else can ignore them. OK, understood. I'll add a few sentences as javadocs. > 2. ExtraFieldUtils and Tests -

Jenkins build is back to normal : Commons-Compress #35

See - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org