Re: [lang] Applying IntelliJ IDEA refactorings

On Jul 9, 2017 18:49, "Matt Sicker" wrote: I personally don't see the point of making a jira issue for it. Agreed. Gary On 9 July 2017 at 20:19, Jonathan Bluett-Duncan wrote: > Okay, thanks for the clarification Gary. > > Does this mean, by

Re: [lang] Applying IntelliJ IDEA refactorings

I personally don't see the point of making a jira issue for it. On 9 July 2017 at 20:19, Jonathan Bluett-Duncan wrote: > Okay, thanks for the clarification Gary. > > Does this mean, by extension, that there's no need to create a new JIRA > issue? In other words, would

Re: [lang] Applying IntelliJ IDEA refactorings

Okay, thanks for the clarification Gary. Does this mean, by extension, that there's no need to create a new JIRA issue? In other words, would just a new GitHub PR be fine (at least for now)? Jonathan On 10 July 2017 at 01:32, Gary Gregory wrote: > I would think an ICLA

Re: [lang] Applying IntelliJ IDEA refactorings

I would think an ICLA is not needed if the only thing we are talking about are clean-up style refactoring. Gary On Sun, Jul 9, 2017 at 2:27 PM, Jonathan Bluett-Duncan < jbluettdun...@gmail.com> wrote: > I've re-read the contribution guidelines >

Re: [dbutils] Preparing for Release; Questions

Hi Carl, As you already are an Apache Committer, I've added you to the Commons Committers group, please try again in a few minutes. Gary On Sun, Jul 9, 2017 at 2:08 PM, Carl Hall wrote: > Hi all, > > I'd like to make a release of dbutils. I've worked through the release

Re: [lang] Applying IntelliJ IDEA refactorings

I've re-read the contribution guidelines , but it's not clear to me if my changes are non-trivial enough to warrant a new JIRA issue. Can someone advise me on this? Jonathan On 6 July 2017 at 00:51, Jonathan Bluett-Duncan

[dbutils] Preparing for Release; Questions

Hi all, I'd like to make a release of dbutils. I've worked through the release preparation guide[1] up to deploying the RC. Rather expectedly, since this is my first attempt at releasing, I'm not able to complete the `mvn deploy` step. ``` Failed to transfer file:

[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test

Github user jlm429 commented on the issue: https://github.com/apache/commons-cli/pull/14 Just adding this diff from the code above if needed for future reference. this pr can be closed - do we possibly need more committers for CLI? It doesn't seem like anyone is paying attention to

[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test

Github user jlm429 commented on the issue: https://github.com/apache/commons-cli/pull/14 Just adding this diff from the code above if needed for future reference. this pr can be closed - do we possibly need more committers for CLI? It doesn't seem like anyone is paying attention to

Re: [daemon] : fixing some general stuff

Hi Bernd/Mark/All, I have raised PR to cover this, would you mind just take a look ? https://github.com/apache/commons-daemon/pull/3 So far I have fixed rat, findbug. I will push javadoc and checkstyle sometime tomorrow. Regards, Amey On Sun, Jul 9, 2017 at 9:34 PM, Amey Jadiye

Re: [daemon] : fixing some general stuff

Thanks Bernd, I had plan B for those crying rat, will put those files to exclusion of checking. I can take care of checkstyle, findbug, javadoc. I'm more interested about test cases now. do we have any options around C code coverage with maven [ java code coverage is easy though], OR even is

Re: [daemon] : fixing some general stuff

On 9 July 2017 15:00:08 BST, Amey Jadiye wrote: >#2. RAT : apache-rat is crying for 4 files, it is ok to add APACHE >LICENSE >but I found they already have GPLv3 in them, shall we replace them, or >we >need consent ? >src/native/unix/support/config.sub

Re: [daemon] : fixing some general stuff

Hello, I think the autoconf related files are generated by GNU tools and cannot be re-licensed. They are not in the binary packages but they do contaminate the source archives. It is not yet mentioned in the NOTICE file but I guess there is a ASF wide regulation for those build scripts. Does

[daemon] : fixing some general stuff

Hi All, I'm going through apache daemon code and trying to fix the stuff breaking with below maven options, also would like to know if some more checks can be added since this repo contains lot of C code. mvn clean verify apache-rat:check clirr:check checkstyle:check findbugs:check