[GitHub] commons-imaging pull request #27: Increase code coverage one

Github user onealj commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/27#discussion_r127632776 --- Diff: src/test/java/org/apache/commons/imaging/formats/jpeg/segments/JfifSegmentTest.java --- @@ -0,0 +1,35 @@ +package

[GitHub] commons-imaging pull request #27: Increase code coverage one

Github user onealj commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/27#discussion_r127633319 --- Diff: src/test/java/org/apache/commons/imaging/formats/tiff/fieldtypes/FieldTypeByteTest.java --- @@ -0,0 +1,37 @@ +package

[GitHub] commons-imaging pull request #27: Increase code coverage one

Github user onealj commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/27#discussion_r127633025 --- Diff: src/test/java/org/apache/commons/imaging/formats/pnm/PbmFileInfoTest.java --- @@ -0,0 +1,41 @@ +package

[GitHub] commons-imaging pull request #27: Increase code coverage one

Github user onealj commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/27#discussion_r127632145 --- Diff: src/test/java/org/apache/commons/imaging/formats/bmp/BmpWriterRgbTest.java --- @@ -0,0 +1,35 @@ +package

[GitHub] commons-imaging pull request #27: Increase code coverage one

Github user onealj commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/27#discussion_r127632387 --- Diff: src/test/java/org/apache/commons/imaging/formats/bmp/BmpWriterRgbTest.java --- @@ -0,0 +1,35 @@ +package

[GitHub] commons-imaging pull request #27: Increase code coverage one

Github user onealj commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/27#discussion_r127632531 --- Diff: src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java --- @@ -66,6 +64,22 @@ protected File createTempFile(final

[GitHub] commons-imaging pull request #27: Increase code coverage one

Github user onealj commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/27#discussion_r127632941 --- Diff: src/test/java/org/apache/commons/imaging/formats/pnm/PbmFileInfoTest.java --- @@ -0,0 +1,41 @@ +package

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC2

I noticed it during mvn clean verify site Gary On Jul 16, 2017 18:34, "Carl Hall" wrote: > Great feedback! Thanks so much. > > Would you please let me know how you're running PMD? I've tried `mvn > pmd:pmd`. I'm not seeing issues locally and would like to make sure the

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC2

Great feedback! Thanks so much. Would you please let me know how you're running PMD? I've tried `mvn pmd:pmd`. I'm not seeing issues locally and would like to make sure the build is bulletproof. On Sun, Jul 16, 2017 at 6:08 PM, Gary Gregory wrote: > +1 > > From src

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC2

+1 >From src zip: ASC, MD5, and SHA1 OK. RAT and CLIRR check OK. Reports look OK. Issues to address but not blockers: - PMD blows up during the build and there is no resulting PMD report. - The POM uses an old version of commons-parent. Gary On Sun, Jul 16, 2017 at 3:41 PM, Carl Hall

[VOTE] Release Apache Commons DbUtils 1.7 based on RC2

Hi, It's been almost 3 years to the day since we've had a DbUtils release. We've fixed several important bugs and added some new features, so I would like to release DbUtils 1.7. Furthermore, we have fixed these issues for RC2, which were discovered in RC1: - resource leaks as found by FindBugs

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC1

Thank you very much for giving this RC a keen review. Being my first release, I appreciate the help in getting this right. I'll incorporate the suggested fixes (thanks, Gary!) to the release branch and prep RC2. On Sun, Jul 16, 2017 at 12:46 PM, Gary Gregory wrote: >

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC1

Hi All, Thank you for performing RM duties for this release. -1: This RC introduces resource leaks as found by FindBugs which are not present in 1.6: org.apache.commons.dbutils.AbstractQueryRunner BugCategoryDetailsLinePriority

[GitHub] commons-imaging pull request #27: Increase code coverage one

Github user asfgit closed the pull request at: https://github.com/apache/commons-imaging/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [daemon] moving to git ? and bump java version.

If someone here is really going to put time and energy into daemon, it would be fantastic to start with a release. It's been so long... Then fiddle away on tweaks, and release again. Gary On Jul 16, 2017 08:49, "Matt Sicker" wrote: > C quality somewhat depends on which

Re: [daemon] moving to git ? and bump java version.

C quality somewhat depends on which version of C you're trying to remain compatible with (I'm guessing C89 due to Windows, though I could be wrong). Valgrind and other tracing tools are typically used. I'd take a look at what OpenOffice is doing for local examples (though they have a crazy build

Re: [lang] - Remove RandomStringUtils deprecation / move it to [text]?

Hello Amey, that seems to be the cleanest solution (although the one requiring the most work). Cheers, Pascal Am 14.07.2017 um 18:59 schrieb Amey Jadiye: Hello Pascal, Thanks for putting this on table, I too think that users need some short code to show up output really quick. How about

Re: [lang] - Remove RandomStringUtils deprecation / move it to [text]?

Am 13.07.2017 um 22:06 schrieb Gary Gregory: Can one be pitch for entry level and the other for advanced use cases? imho yes If so, just un-deprecate but still Javadoc to [text] the user's edification. sounds good - To

Re: PR Merge process lang vs text ?

As far as I know the commit is only displayed as merged on git hub if it was not altered in any way. Forhttps://github.com/apache/commons-lang/pull/274 I appended "( closes

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC1

Build and Tests are passing clean, clirr and rat looks good. there are few of bugs in findbug and checkstyle report but they are non-blocker to release. hashes looks good. site looks fine. Here is my +1 to release (non-binding) Checked on :- Apache Maven 3.3.9