[GitHub] commons-dbutils issue #2: This is not a real pull request, just give some su...

2017-10-28 Thread drinkjava2
Github user drinkjava2 commented on the issue: https://github.com/apache/commons-dbutils/pull/2 As naming conflict to "apache/commons-dbutils" , the pull request project "DbUtils-Pro" be deleted from my Github, the similar project can see new project "jDbPro". ---

[GitHub] commons-dbutils pull request #2: This is not a real pull request, just give ...

2017-10-28 Thread drinkjava2
Github user drinkjava2 closed the pull request at: https://github.com/apache/commons-dbutils/pull/2 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail:

Re: [dbcp] update to pool 2.4.3.

2017-10-28 Thread Bruno P. Kinoshita
Hi Gary, Started the tests in Maven command line, found which tests failed. Executed the tests in Eclipse, found which class was related to the failure. Then did a diff between both tags. git diff POOL_2_4_2 POOL_2.4.3-RC1 --

Re: [LOGGING] Logging is Java 1.2 but required Java 1.4 code

2017-10-28 Thread Ralph Goers
Gary, As you know Log4j has a maven module for Java 9. It contains the module-info.java file. That module compiles with Java 9 and targets Java 9 as there isn’t much point targeting anything earlier. That class files produced are then overlaid on top of the classes produced for Log4j-api,

Re: [pool] Drop Ant build?

2017-10-28 Thread Jochen Wiedmann
On Sat, Oct 28, 2017 at 7:43 PM, Gary Gregory wrote: > OK to drop Ant build? Absolutely! -- The next time you hear: "Don't reinvent the wheel!" http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/evolution-of-the-wheel-300x85.jpg

[dbcp] update to pool 2.4.3.

2017-10-28 Thread Gary Gregory
Hi All, After updating dbcp to 2.4.3 I am seeing two unit test failures. I have to step out for the day and I am hoping someone can help figure out what is going on. Gary

Re: [pool] Using Java 7 and next version label

2017-10-28 Thread Pascal Schumacher
I would prefer 2.5. Upping the required java version in a bugfix release seems unusual imho. -Pascal Am 28.10.2017 um 21:03 schrieb Gary Gregory: Hi All, With [pool] moving from Java 6 to 7, should the next version of [pool] be 2.4.4 or 2.5? Opinions? Gary

Re: [pool] Using Java 7 and next version label

2017-10-28 Thread Mark Thomas
On 28/10/17 20:03, Gary Gregory wrote: > Hi All, > > With [pool] moving from Java 6 to 7, should the next version of [pool] be > 2.4.4 or 2.5? Opinions? 2.5 Mark - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For

[pool] Using Java 7 and next version label

2017-10-28 Thread Gary Gregory
Hi All, With [pool] moving from Java 6 to 7, should the next version of [pool] be 2.4.4 or 2.5? Opinions? Gary

Re: [LANG] Merge PR for adding module-info

2017-10-28 Thread Pascal Schumacher
Am 28.10.2017 um 08:59 schrieb Benedikt Ritter: Note that Commons Lang will still work and build on Java 7 after this is merged, but for releasing the RM has to make sure the release is built with Java 9. Just to clarify: Unless I missed something this should be: "Releases have to be in two

Re: [pool] Drop Ant build?

2017-10-28 Thread Pascal Schumacher
+1 Am 28.10.2017 um 19:43 schrieb Gary Gregory: Hi All, OK to drop Ant build? Gary - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[pool] Drop Ant build?

2017-10-28 Thread Gary Gregory
Hi All, OK to drop Ant build? Gary

Re: [RESULT][VOTE][LAZY] Migrate Apache Commons Validator to git

2017-10-28 Thread Gary Gregory
Benedikt: Thank you again for shepherding this through. On Sat, Oct 28, 2017 at 10:37 AM, Benedikt Ritter wrote: > Hi, > > > Am 21.10.2017 um 10:22 schrieb Benedikt Ritter : > > > > Hello, > > > > I’d like to move Apache Commons Validator codebase to git,

Re: [RESULT][VOTE][LAZY] Migrate Apache Commons BCEL to git

2017-10-28 Thread Gary Gregory
Benedikt: Thank your shepherding this through. Gary On Sat, Oct 28, 2017 at 10:36 AM, Benedikt Ritter wrote: > Hi, > > > Am 21.10.2017 um 10:21 schrieb Benedikt Ritter : > > > > Hello, > > > > I’d like to move Apache Commons BCEL codebase to git, so I’m

Re: [LOGGING] Logging is Java 1.2 but required Java 1.4 code

2017-10-28 Thread Gary Gregory
>From a pragmatic POV, the oldest Java byte codes you can get Java 9 to emit are for Java 1.6. Since we will want, I assume, to produce a module info class in the jar, we will need to use Java 9 for that (to keep an RM's life manageable.) This means to me that we should set the bar at Java 1.6

[RESULT][VOTE][LAZY] Migrate Apache Commons Validator to git

2017-10-28 Thread Benedikt Ritter
Hi, > Am 21.10.2017 um 10:22 schrieb Benedikt Ritter : > > Hello, > > I’d like to move Apache Commons Validator codebase to git, so I’m calling a > vote by lazy consensus. If nobody objects within the next 72 hours this vote > passes and I will start with the migration. >

[RESULT][VOTE][LAZY] Migrate Apache Commons BCEL to git

2017-10-28 Thread Benedikt Ritter
Hi, > Am 21.10.2017 um 10:21 schrieb Benedikt Ritter : > > Hello, > > I’d like to move Apache Commons BCEL codebase to git, so I’m calling a vote > by lazy consensus. If nobody objects within the next 72 hours this vote > passes and I will start with the migration. > >

Re: [LOGGING] Logging is Java 1.2 but required Java 1.4 code

2017-10-28 Thread Gary Gregory
I was trying to follow Stephen's guidance that the build needs Java 9 and the code can stay at Java 6-8. Gary On Oct 28, 2017 10:21, "Ralph Goers" wrote: > That isn’t strictly true Gary, There are ways to build the module-info > without upgrading the main code to

Re: [LOGGING] Logging is Java 1.2 but required Java 1.4 code

2017-10-28 Thread Benedikt Ritter
Hello, maybe we should decide on what we want to achieve here, before I start the endeavor of creating an RC for such an old component. My understanding of Logging is, that it is in semi dormant mode. That we don’t want to add any new features and instead point users to Log4j2. Since Logging

Re: [LOGGING] Logging is Java 1.2 but required Java 1.4 code

2017-10-28 Thread Ralph Goers
That isn’t strictly true Gary, There are ways to build the module-info without upgrading the main code to Java 9. That said, it is a bit of a hack to do it. Ralph > On Oct 28, 2017, at 8:19 AM, Gary Gregory wrote: > > Let's update to at least a minimum of Java 6 such

[RESULT][VOTE] Release Apache Commons Pool 2.4.3 based on RC1

2017-10-28 Thread Gary Gregory
This VOTE passes with three (3) +1 votes from the following PMC members: Bruno P. Kinoshita Gary Gregory Pascal Schumacher Thank you for reviewing this RC. I'll proceed with the release. Gary On Tue, Oct 24, 2017 at 9:19 PM, Gary Gregory wrote: > We have fixed a few bugs

Re: [LOGGING] Logging is Java 1.2 but required Java 1.4 code

2017-10-28 Thread Gary Gregory
Let's update to at least a minimum of Java 6 such that the build can run with Java 9. Builing with Java 9 will be a requirement to add module info. Gary On Oct 28, 2017 01:21, "Benedikt Ritter" wrote: > Hi all, > > After I was able to update the the build to the latest

[GitHub] commons-text pull request #73: Exception thrown in ExtendedMessageFormat usi...

2017-10-28 Thread kinow
GitHub user kinow opened a pull request: https://github.com/apache/commons-text/pull/73 Exception thrown in ExtendedMessageFormat using quotes with custom registry Created this pull request from the patch provided by Benoît Moreau in

[LOGGING] Logging is Java 1.2 but required Java 1.4 code

2017-10-28 Thread Benedikt Ritter
Hi all, After I was able to update the the build to the latest parent POM, I’m running into animal sniffer problems. The build is defined to target Java 1.2 but there are classes which require later JDKs: - Jdk13LumberjackLogger - Jdk14Logger This breaks the build because animal sniffer

Re: [LOGGING] Problems updating to lastest commons parent

2017-10-28 Thread Benedikt Ritter
> Am 25.10.2017 um 05:32 schrieb Gary Gregory : > > Remove the version specifier for build-helper-maven-plugin, this will pick > up the version from the parent POM, which I locally updated from 34 to 42. > Then you'll run into some other error due to how this old build

Re: [VOTE] Release Apache Commons JCS 2.2.1 (roll 2)

2017-10-28 Thread Benedikt Ritter
> Am 27.10.2017 um 12:51 schrieb Thomas Vandahl : > > Hi Gary, > > On 25.10.17 05:24, Gary Gregory wrote: >> Our process documented here http://commons.apache.org/releases/prepare.html >> makes it pretty clear that the RC tag should be labeled as such and that a >> tag like

[LANG] Merge PR for adding module-info

2017-10-28 Thread Benedikt Ritter
Hi, Stephen Colebourne has done a great job adding a module-info.java file to Commons Lang [1]. This can serve as an example for other components. Since Commons is pretty conservative when it comes to adopting new Java features, I’d like to ask a last time for feedback on the PR. Note that