Github user sfuhrm commented on the issue:
https://github.com/apache/commons-collections/pull/40
BTW, TravisCI is right, technically this is an API change, but I suggest
that all API uses are neither useful nor make sense.
---
---
GitHub user sfuhrm opened a pull request:
https://github.com/apache/commons-collections/pull/40
COLLECTIONS-685: IterableUtils has public constructor
Constructor for Utils class was not private.
This was obviously not intended as all other Utils classes have private
constructor
Github user wangyulin commented on the issue:
https://github.com/apache/commons-pool/pull/7
Add ```getState()``` on ```PooledObject```, checkAPIcompatibility failed.
---
-
To unsubscribe, e-mail: dev-unsubscr...@comm
GitHub user wangyulin opened a pull request:
https://github.com/apache/commons-pool/pull/7
Refactor PooledObject and BaseGenericObjectPool
```PooledObject``` should not pay attention to ```idleObjects``` of
```GenericObjectPool```, so there should be no ```idleQueue.offerFirst
(thi
On 11 June 2018 at 21:13, Rob Tompkins wrote:
>
>
>> On Jun 11, 2018, at 3:55 PM, Gary Gregory wrote:
>>
>> The best IMO is “commons.packageId” for "lang3”.
>
> Sounds good….will head that direction.
I think the most important aspect is to very carefully document what
the variable is used for.
> On Jun 11, 2018, at 3:55 PM, Gary Gregory wrote:
>
> The best IMO is “commons.packageId” for "lang3”.
Sounds good….will head that direction.
>
> Gary
>
> On Mon, Jun 11, 2018 at 1:41 PM Rob Tompkins wrote:
>
>>
>>
>>> On Jun 11, 2018, at 11:58 AM, Gary Gregory
>> wrote:
>>>
>>> I t
The best IMO is “commons.packageId” for "lang3".
Gary
On Mon, Jun 11, 2018 at 1:41 PM Rob Tompkins wrote:
>
>
> > On Jun 11, 2018, at 11:58 AM, Gary Gregory
> wrote:
> >
> > I think the first statement needs to be checked and code maybe changed to
> > adjust for the fact that we have both the
> On Jun 11, 2018, at 11:58 AM, Gary Gregory wrote:
>
> I think the first statement needs to be checked and code maybe changed to
> adjust for the fact that we have both the artifact id and component id to
> play with.
The issue is that we only have two names for 3 values. Values, for lang:
Github user coveralls commented on the issue:
https://github.com/apache/commons-collections/pull/39
[](https://coveralls.io/builds/17432328)
Coverage increased (+0.7%) to 87.386% when pulling
**883ea5426f372e2
Side note: geronimo just started to implement Microprofile metrics which is
a kind of copy of the dropwizard/codehale API, maybe it can be a place to
host this kind of thing too. [1] is quite close I think
[1]
https://gitbox.apache.org/repos/asf?p=geronimo-metrics.git;a=blob;f=src/main/java/org/ap
GitHub user sfuhrm opened a pull request:
https://github.com/apache/commons-collections/pull/39
Flat3Map: Some test cases going more into the details
Flat3Map is quite complex in that there are many many ifs. I've added some
test cases to validate the correct function of the map in
Thanks to everyone who took that time to review.
Although my preference was to contribute this utility back to commons, it seems
like it has kind
of spiraled into something much more, and there doesn’t seem to be a clear
consensus.
So if you think it was useful :
you grab it now from
https:/
Hi All,
Just FYI and per Apache guidelines, I am going to replace @author tags with
listing in the pom.xml file.
Gary
Github user asfgit closed the pull request at:
https://github.com/apache/commons-pool/pull/6
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
I think the first statement needs to be checked and code maybe changed to
adjust for the fact that we have both the artifact id and component id to
play with.
The page generation works now BTW with the SNAPSHOT build, which I used for
Commons Text 1.4 RC1.
Gary
On Mon, Jun 11, 2018 at 9:39 AM Ro
I’m a tad worried about these two conflicting statements (thoughts?):
--
commons-lang, pom.xml: 562-573
lang3
--
commons-parent, pom.xml: 1847-1854
${project.artifactId}
-
T
On Mon, Jun 11, 2018 at 9:30 AM Rob Tompkins wrote:
> …I was vague there….
>
> Moving appending the version-RcVersion directory mechanics up into the
> release plugin because we can’t check out from a non existent directory in
> svn. So we’ll checkout the top level directory, and create the
> ver
…I was vague there….
Moving appending the version-RcVersion directory mechanics up into the release
plugin because we can’t check out from a non existent directory in svn. So
we’ll checkout the top level directory, and create the version-RcVersion
directory programmatically in the plugin.
> On
Working on migrating that to the release plugin. Need it in there for adding it
to svn properly.
> On Jun 11, 2018, at 11:11 AM, Gary Gregory wrote:
>
>> On Mon, Jun 11, 2018 at 8:47 AM wrote:
>>
>> Author: chtompki
>> Date: Mon Jun 11 14:47:34 2018
>> New Revision: 185
>>
>> URL: http:
On Mon, Jun 11, 2018 at 8:47 AM wrote:
> Author: chtompki
> Date: Mon Jun 11 14:47:34 2018
> New Revision: 185
>
> URL: http://svn.apache.org/viewvc?rev=185&view=rev
> Log:
> COMMONSSITE-113: moving staging by rc version logic to release plugin
>
> Modified:
> commons/proper/commons-p
Tracking here: https://issues.apache.org/jira/browse/DBCP-503
On Mon, Jun 11, 2018 at 2:27 AM Mark Thomas wrote:
> On 10/06/18 17:14, Gary Gregory wrote:
> >
> org.apache.commons.dbcp2.datasources.InstanceKeyDataSourceFactory.closeAll()
> > does not close all if one of delegated close() calls th
> On Jun 11, 2018, at 9:06 AM, Rob Tompkins wrote:
>
>
>
>> On Jun 11, 2018, at 9:05 AM, Rob Tompkins wrote:
>>
>> I’m going to fake stage text-1.4-SNAPSHOT now to test this… with the
>> SNAPSHOT parent.
> snip
>
> 1.5-SNAPSHOT**
>
>>
>> -Rob
>>
>>> On Jun 9, 2018, at 1:18 PM, Gary Gr
> On Jun 11, 2018, at 9:05 AM, Rob Tompkins wrote:
>
> I’m going to fake stage text-1.4-SNAPSHOT now to test this… with the SNAPSHOT
> parent.
snip
1.5-SNAPSHOT**
>
> -Rob
>
>> On Jun 9, 2018, at 1:18 PM, Gary Gregory wrote:
>>
>> I deleted the files in dist SVN to handle the previous e
I’m going to fake stage text-1.4-SNAPSHOT now to test this… with the SNAPSHOT
parent.
-Rob
> On Jun 9, 2018, at 1:18 PM, Gary Gregory wrote:
>
> I deleted the files in dist SVN to handle the previous error.
> But now, here is another:
>
> [INFO] --- commons-release-plugin:1.3-SNAPSHOT:stage-d
I haven’t seen that one before. Let me see what happens when I run it.
-Rob
> On Jun 10, 2018, at 4:10 PM, Oliver Heger
> wrote:
>
> Hi all,
>
> I tried to update the pom of [configuration] to commons-parent 46. When
> I build the site I get the error below.
>
> [configuration] has a number
> On Jun 9, 2018, at 1:08 PM, Gary Gregory wrote:
>
> Hi Rob:
>
> We should handle this case:
After thinking about this, your change to the [parent] should accommodate this
as we uniquely path new release candidates. That said, we still should delete
everything in the directory if it’s non
On 09/06/18 05:20, ggreg...@apache.org wrote:
> Repository: commons-dbcp
> Updated Branches:
> refs/heads/master b3654dbd3 -> 735d9a839
>
>
> [DBCP-496] Add support for pooling CallableStatements to the
> org.apache.commons.dbcp2.cpdsadapter package.
This would have been easier to review with
On 10/06/18 17:14, Gary Gregory wrote:
> org.apache.commons.dbcp2.datasources.InstanceKeyDataSourceFactory.closeAll()
> does not close all if one of delegated close() calls throws an exception.
>
> I would think we would want to close all no matter what and then save the
> first exception caught a
28 matches
Mail list logo
