[GitHub] darkma773r closed pull request #14: GEOMETRY-14: Initial AffineTransform3D class

2018-10-16 Thread GitBox
darkma773r closed pull request #14: GEOMETRY-14: Initial AffineTransform3D class URL: https://github.com/apache/commons-geometry/pull/14 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

Re: [numbers] Making fractions VALJOs

2018-10-16 Thread Gilles
On Tue, 16 Oct 2018 16:55:02 -0700, Eric Barnhill wrote: The Fraction class is IMO looking good (in better shape than Complex was in) and is already quite close to fulfilling the standards for a VALJO. Equals() and CompareTo() are well designed and consistent. I see two missing steps. The easy

Re: [ALL] Spaces in paths - change Jenkins jobs to use spaces?

2018-10-16 Thread Gary Gregory
Sounds reasonable but we need unit tests that also include spaces so that we do rely on the build location as a test. Gary On Tue, Oct 16, 2018, 17:39 sebb wrote: > IO-589 was accidentally found by trying to test in a path which > happened to contain a space. > This revealed a bug (in test

Re: [numbers] Making fractions VALJOs

2018-10-16 Thread Eric Barnhill
The Fraction class is IMO looking good (in better shape than Complex was in) and is already quite close to fulfilling the standards for a VALJO. Equals() and CompareTo() are well designed and consistent. I see two missing steps. The easy one is a parse() method which mirrors the toString() method.

[ALL] Spaces in paths - change Jenkins jobs to use spaces?

2018-10-16 Thread sebb
IO-589 was accidentally found by trying to test in a path which happened to contain a space. This revealed a bug (in test code) which did not properly convert from URL path to file system path. I think it would make sense to rename the Jenkins jobs to ensure all the tests have a space in the

Re: build failes for commons-io

2018-10-16 Thread Aleksander Ściborek
I've just updated my fork and everything is ok. Thank you very much :) On Wed, Oct 17, 2018, 01:11 sebb wrote: > I've raised a bug (IO-589) and fixed it, so thanks again for finding the > error. > It was a bug in the test code. > > >

Re: build failes for commons-io

2018-10-16 Thread sebb
I've raised a bug (IO-589) and fixed it, so thanks again for finding the error. It was a bug in the test code. On Tue, 16 Oct 2018 at 15:36, sebb wrote: > > On Tue, 16 Oct 2018 at 00:43, Aleksander Ściborek > wrote: > > > > I think I've found actually reasos for my problems, it's seems it was >

[RESULT][VOTE] Release Apache Commons Text 1.6 based on RC1

2018-10-16 Thread Rob Tompkins
This [VOTE] passes with the following votes in order of appearance: Gary Gregory: +1, Pascal Schumacher: +1, and Rob Tompkins: +1. Many thanks for all of the effort that went into this release. I will perform the release processes now, and I’ll send out the announcement tomorrow. Cheers, -Rob

Re: [VOTE] Release Apache Commons Text 1.6 based on RC1

2018-10-16 Thread Rob Tompkins
Here’s my +1 on the [VOTE]. -Rob > On Oct 12, 2018, at 10:01 PM, Rob Tompkins wrote: > > We have fixed quite a few bugs and added some significant enhancements since > Apache Commons Text 1.5 was released, so I would like to release Apache > Commons Text 1.6. > > Apache Commons Text 1.6 RC1

Re: build failes for commons-io

2018-10-16 Thread sebb
On Tue, 16 Oct 2018 at 00:43, Aleksander Ściborek wrote: > > I think I've found actually reasos for my problems, it's seems it was > caused by long path and spaces in directories names - I run mvn clean > package in tmp folder and everything has passed Ah, thanks for letting us know. However,

Re: [bcel] 6.3 release need awareness

2018-10-16 Thread Gary Gregory
Yes, I would like to but as we are all volunteers here, it is more of a matter of a PMC member wanting to take the time to do it... In the meantime, you could confirm that the 6.3-SNAPSHOT works for you as is? Gary On Tue, Oct 16, 2018 at 8:27 AM Martin Muller wrote: > Hi developers. > > We

[bcel] 6.3 release need awareness

2018-10-16 Thread Martin Muller
Hi developers. We from www.alfresco.com are currently updating from Java 8 to Java 11. We are relying strongly on JIBX for binding XML files to Java objects. There was a problem with the BCEL lib which was fixed in