Re: Using email addresses in exception messages

2019-05-12 Thread Emmanuel Bourg
Le 12/05/2019 à 14:25, Gary Gregory a écrit : > +1 to removing email addresses from exception messages. We should do a pass > over all of Commons. +1, makes sense. Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@commons

[compress] resource leak in example code

2019-05-12 Thread Stefan Bodewig
Hi all https://issues.apache.org/jira/browse/COMPRESS-486 highlights a problem of the code inside the example package. The methods with stream or channel arguments create wrapper objects around said streams or channels and never close them. They don't close them because this in turn would close th

Re: Using email addresses in exception messages

2019-05-12 Thread Gary Gregory
+1 to removing email addresses from exception messages. We should do a pass over all of Commons. Gary On Sun, May 12, 2019, 06:46 sebb wrote: > Some of our code has Exception messages such as the following: > > >> (Collections:LRUMap) > throw new IllegalStateException("Entry.before is null." +

Re: Using email addresses in exception messages

2019-05-12 Thread Rob Tompkins
> On May 12, 2019, at 6:45 AM, sebb wrote: > > Some of our code has Exception messages such as the following: > >>> (Collections:LRUMap) > throw new IllegalStateException("Entry.before is null." + > " Please check that your keys are immutable, and that you have used > synchronization properly

Using email addresses in exception messages

2019-05-12 Thread sebb
Some of our code has Exception messages such as the following: >> (Collections:LRUMap) throw new IllegalStateException("Entry.before is null." + " Please check that your keys are immutable, and that you have used synchronization properly." + " If so, then please report this to dev@commons.apache.o