[numbers-fraction] Code duplication between FractionTest and BigFractionTest

2019-06-19 Thread Heinrich Bohne
An awful lot of code is duplicated between FractionTest and BigFractionTest. Often, the test cases in the two classes only differ in the types they use (e.g. Fraction vs. BigFraction), but the actual values the tests use are the same. I think this could be mitigated by adding a new class that

Re: [GSoC][Commons][STATISTICS][Regression][Matrix] Flexibility in Matrix Libraries in Regression Component?

2019-06-19 Thread Gilles Sadowski
Hi. Le mer. 19 juin 2019 à 18:39, Eric Barnhill a écrit : > > On Mon, Jun 17, 2019 at 7:13 AM Ben Nguyen wrote: > > > I don’t believe the plan is or that the use of EJML should be permanent…. > > > > > There's no reason it couldn't be permanent. Obviously we want to give > credit where it is

Re: [GSoC][STATISTICS][Regression][Exception] How should I handlehandling exceptions?

2019-06-19 Thread Gilles Sadowski
Hi. Le mer. 19 juin 2019 à 19:03, Ben Nguyen a écrit : > > Hello, > > Inside AbstractMultipleLinearRegression.java in commons.math3.stat.regression > /// > > import

Re: [GSoC][STATISTICS][Regression][Exception] How should I handle handling exceptions?

2019-06-19 Thread Gilles Sadowski
Hi. Le mer. 19 juin 2019 à 18:39, Alex Herbert a écrit : > > On 19/06/2019 17:33, Ben Nguyen wrote: > > Hello, > > Regarding the use of exceptions for the regression module; should I simply > > try to port over all required exceptions straight from > > “apache.commons.math.exception” into it’s

Re: [GSoC][STATISTICS][Regression][Exception] How should I handlehandling exceptions?

2019-06-19 Thread Alex Herbert
> On 19 Jun 2019, at 18:03, Ben Nguyen wrote: > > Hello, > > Inside AbstractMultipleLinearRegression.java in commons.math3.stat.regression > /// > > import

RE: [GSoC][STATISTICS][Regression][Exception] How should I handlehandling exceptions?

2019-06-19 Thread Ben Nguyen
Hello, Inside AbstractMultipleLinearRegression.java in commons.math3.stat.regression /// import org.apache.commons.math3.exception.DimensionMismatchException; import

Re: [GSoC][Commons][STATISTICS][Regression][Matrix] Flexibility in Matrix Libraries in Regression Component?

2019-06-19 Thread Eric Barnhill
On Mon, Jun 17, 2019 at 7:13 AM Ben Nguyen wrote: > I don’t believe the plan is or that the use of EJML should be permanent…. > There's no reason it couldn't be permanent. Obviously we want to give credit where it is due in all the appropriate ways. But the code is licensed so that others may

Re: [GSoC][STATISTICS][Regression][Exception] How should I handle handling exceptions?

2019-06-19 Thread Alex Herbert
On 19/06/2019 17:33, Ben Nguyen wrote: Hello, Regarding the use of exceptions for the regression module; should I simply try to port over all required exceptions straight from “apache.commons.math.exception” into it’s own exception package inside “regression.util.exception” perhaps

[GSoC][STATISTICS][Regression][Exception] How should I handle handling exceptions?

2019-06-19 Thread Ben Nguyen
Hello, Regarding the use of exceptions for the regression module; should I simply try to port over all required exceptions straight from “apache.commons.math.exception” into it’s own exception package inside “regression.util.exception” perhaps customizing them to regression’s specific use

Re: [commons-daemon] 02/02: Update RAT config to exclude generated files and autoconf related files

2019-06-19 Thread Mark Thomas
On 19/06/2019 12:24, Rob Tompkins wrote: > Given that the files were auto-generated, do we require another RC? I > think that the precedent is yes, but the question I think is a > reasonable one. ASF policy doesn't require another RC in these circumstances. Whether we choose to is a slightly

Re: [commons-daemon] 02/02: Update RAT config to exclude generated files and autoconf related files

2019-06-19 Thread Rob Tompkins
Given that the files were auto-generated, do we require another RC? I think that the precedent is yes, but the question I think is a reasonable one. -Rob On 6/19/2019 6:46 AM, ma...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit

Re: [VOTE] Release Apache Commons Daemon 1.1.1

2019-06-19 Thread Mark Thomas
On 19/06/2019 10:44, Jonathan Gallimore wrote: > This works well in my tests, many thanks for the release. Thanks for the confirmation. Mark > > (non-binding) +1. > > Jon > > On Mon, Jun 17, 2019 at 1:13 PM Mark Thomas wrote: > >> It has been ~18 months since the last Commons Daemon

Re: [VOTE] Release Apache Commons Daemon 1.1.1

2019-06-19 Thread Jonathan Gallimore
This works well in my tests, many thanks for the release. (non-binding) +1. Jon On Mon, Jun 17, 2019 at 1:13 PM Mark Thomas wrote: > It has been ~18 months since the last Commons Daemon release. After the > recent flurry of activity, I think we are ready for a release. > > Notable changes

Re: [VOTE] Release Apache Commons Daemon 1.1.1

2019-06-19 Thread Mark Thomas
On 19/06/2019 02:04, Rob Tompkins wrote: > Build works on java8 with “mvn clean test install site.” On java7 and java11 > “mvn clean test” works. Great. Thanks for looking. > One curiousity, “mvn apache-rat:check” fails with 4 license violations, > namely: > >