Re: Broken source links

2019-07-20 Thread Gary Gregory
I've updated the site.xml files. Gary On Sat, Jul 20, 2019 at 8:41 PM Gary Gregory wrote: > arg, the site.xml files must be updated to point to scm.html... > > Gary > > On Sat, Jul 20, 2019 at 6:27 PM Phil Steitz wrote: > >> Hi all, >> >> I have noticed that several components - e.g. [pool],

Re: Broken source links

2019-07-20 Thread Gary Gregory
arg, the site.xml files must be updated to point to scm.html... Gary On Sat, Jul 20, 2019 at 6:27 PM Phil Steitz wrote: > Hi all, > > I have noticed that several components - e.g. [pool], [dbcp], [lang] now > return 404s when you click the "Source Repository" link on the left > nav. It looks

Re: [pool] OK to commit?

2019-07-20 Thread Gary Gregory
Go for it. As Matt pointed out, you can always create a PR and see have Travis validate builds. Gary On Sat, Jul 20, 2019 at 7:45 PM Phil Steitz wrote: > I am working on a patch for POOL-361. I think the analysis in the > ticket is correct and I think I know how to fix it (move validation

Re: [pool] OK to commit?

2019-07-20 Thread James Carman
If you feel nervous, you can always push a branch or something and let folks take a look. On Sat, Jul 20, 2019 at 8:06 PM Matt Sicker wrote: > I believe it’s CTR on Pool, so go for it. > > On Sat, Jul 20, 2019 at 18:45, Phil Steitz wrote: > > > I am working on a patch for POOL-361. I think

Re: [pool] OK to commit?

2019-07-20 Thread Matt Sicker
I believe it’s CTR on Pool, so go for it. On Sat, Jul 20, 2019 at 18:45, Phil Steitz wrote: > I am working on a patch for POOL-361. I think the analysis in the > ticket is correct and I think I know how to fix it (move validation into > create()). I think I still have commit karma, but have

[pool] OK to commit?

2019-07-20 Thread Phil Steitz
I am working on a patch for POOL-361.  I think the analysis in the ticket is correct and I think I know how to fix it (move validation into create()).  I think I still have commit karma, but have not committed to commons in quite a while.  Any objections to me committing directly to [pool]?

Fwd: Re: Broken source links

2019-07-20 Thread Phil Steitz
Sorry, missed the list ... On 7/20/19 5:41 PM, Gary Gregory wrote: In this vein, our main page http://commons.apache.org/ has a menu item on the LHS called "Components" under "Source Repositories" that still points to Subversion http://svn.apache.org/viewvc/commons/proper/ instead of git repos

Re: Broken source links

2019-07-20 Thread Gary Gregory
In this vein, our main page http://commons.apache.org/ has a menu item on the LHS called "Components" under "Source Repositories" that still points to Subversion http://svn.apache.org/viewvc/commons/proper/ instead of git repos for which there is not a single link so maybe we should just remove

Broken source links

2019-07-20 Thread Phil Steitz
Hi all, I have noticed that several components - e.g. [pool], [dbcp], [lang] now return 404s when you click the "Source Repository" link on the left nav.  It looks like the file, "source-repository.html" referenced in site.xml for these components is no longer being generated by the site

Re: [crypto] Committer Support to Commons Crypto

2019-07-20 Thread Alex Remily
Thanks for the response Gary. I'll point out to potential reviewers that the native component of this project and some limitations of Travis complicate the testing process. Commons crypto provides a Java wrapper around OpenSSL on Windows, OS X and Linux, so testing the PR involves building and

Re: [codec] Next Commons Codec Release Date

2019-07-20 Thread Gary Gregory
I created a release candidate this morning. If all goes well we should have a 1.13 release in 72 hours or so. Gary On Wed, May 29, 2019, 20:18 Gary Gregory wrote: > Hi Jack, > > There are no current release plans. There are a couple of other components > I'd like to release as well. So it is

Re: [numbers-core] Special cases in greatest common divisor methods

2019-07-20 Thread Alex Herbert
> On 20 Jul 2019, at 17:08, Heinrich Bohne wrote: > >> This separates the result into three: >> >> - representable signed integer >> - representable unsigned integer (your new Integer.MIN_VALUE case) >> - unknown result (exception) > > Maybe I misunderstood you, but with my suggested

Re: [numbers-core] Special cases in greatest common divisor methods

2019-07-20 Thread Heinrich Bohne
This separates the result into three: - representable signed integer - representable unsigned integer (your new Integer.MIN_VALUE case) - unknown result (exception) Maybe I misunderstood you, but with my suggested changes, the method would never throw an exception, because the gcd of two

[VOTE] Release Apache Commons Codec 1.13 based on RC1

2019-07-20 Thread Gary Gregory
We have fixed quite a few bugs and added some significant enhancements since Apache Commons Codec 1.12 was released, so I would like to release Apache Commons Codec 1.13. Apache Commons Codec 1.13 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/codec/1.13-RC1

Re: [crypto] Committer Support to Commons Crypto

2019-07-20 Thread Gary Gregory
Hi Alex, Indeed, there has not been much activity in Commons Crypto :-( Anyone else care to comment on the PR? Gary On Fri, Jul 19, 2019 at 10:21 PM Alex Remily wrote: > Are there any active committers on the commons-crypto project? I've had a > PR outstanding for a few months that could

Re: [numbers-core] Special cases in greatest common divisor methods

2019-07-20 Thread Alex Herbert
> On 20 Jul 2019, at 10:53, Heinrich Bohne wrote: > > I have suggestion regarding what to do with the special cases > Integer.MIN_VALUE and Long.MIN_VALUE in the methods from ArithmeticUtils > that calculate the greatest common divisor of two ints or longs. > Currently, these methods throw an

[numbers-core] Special cases in greatest common divisor methods

2019-07-20 Thread Heinrich Bohne
I have suggestion regarding what to do with the special cases Integer.MIN_VALUE and Long.MIN_VALUE in the methods from ArithmeticUtils that calculate the greatest common divisor of two ints or longs. Currently, these methods throw an ArithmeticException if the GCD of the arguments is 2^31 or

Re: [GSoC][Commons][Statistics][Descriptive] Mean should be initiated with 0 or NaN ?

2019-07-20 Thread Alex Herbert
On Sat, 20 Jul 2019, 02:00 Virendra singh Rajpurohit, < virendrasing...@gmail.com> wrote: > > > > The code just needs to move the logic for checking if there are any > values > > (count > 0) into the getMean() method and return appropriately. This > should > > be added to the contract of Mean by