Re: [ALL] Where should an OrderedObservable live in Commons?

2019-08-19 Thread Gary Gregory
On Tue, Jul 10, 2018 at 12:05 PM sebb wrote: > What are the common use cases for this? > Do they come from a particular field, and if so, where would you > expect to find related code in Commons? > > Just a thought. > > If there are likely to be more classes in the same general area, maybe > you

Re: Fix for the ArrayIndexOutOfBoundsException on calling NaturalRanking#rank() on an array of all NaNs

2019-08-19 Thread Gilles Sadowski
Hi. 2019-08-19 17:10 UTC+02:00, Alex Herbert : > >> On 19 Aug 2019, at 15:45, akash srivastava wrote: >> >> I was advised to check with the dev mailing list if anyone has a problem >> with the suggested fix. >> It seems no one does have a problem with the fixes suggested so I'll go >> forward

[vfs] Misplaced commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/providers.xml ?

2019-08-19 Thread Gary Gregory
It seems to me the provider.xml file should not be in: commons-vfs2/src/main/*java*/org/apache/commons/vfs2/impl/providers.xml but instead if commons-vfs2/src/main/*resources*/org/apache/commons/vfs2/impl/providers.xml Thoughts? Gary

Re: Fix for the ArrayIndexOutOfBoundsException on calling NaturalRanking#rank() on an array of all NaNs

2019-08-19 Thread Alex Herbert
> On 19 Aug 2019, at 15:45, akash srivastava wrote: > > I was advised to check with the dev mailing list if anyone has a problem > with the suggested fix. > It seems no one does have a problem with the fixes suggested so I'll go > forward and create a PR that returns an empty array for an

Re: Fix for the ArrayIndexOutOfBoundsException on calling NaturalRanking#rank() on an array of all NaNs

2019-08-19 Thread akash srivastava
I was advised to check with the dev mailing list if anyone has a problem with the suggested fix. It seems no one does have a problem with the fixes suggested so I'll go forward and create a PR that returns an empty array for an array of all NaNs. On Thu, Aug 15, 2019 at 11:25 AM akash srivastava