Re: [configuration] dropping @author tags

2019-09-05 Thread sebb
On Thu, 5 Sep 2019 at 21:03, Gary Gregory wrote: > > Hi All: > > Like we have elsewhere, I will be dropping @author tags from Java sources. As I recall, previously they were moved to the pom rather than being totally dropped. > Gary

[VOTE] Release Apache Commons Daemon 1.2.1 RC1

2019-09-05 Thread Mark Thomas
A couple of regressions have been identified in the 1.2.0 release so I'd like to get 1.2.1 released to address them. So, time for another release vote. Notable changes since 1.2.0 include: - Correct a regression (DAEMON-401) that caused 32-bit Windows services to crash on start-up - Correct a

[configuration] dropping @author tags

2019-09-05 Thread Gary Gregory
Hi All: Like we have elsewhere, I will be dropping @author tags from Java sources. Gary

Re: [lang] Missing Javadocs

2019-09-05 Thread Pascal Schumacher
Checkstyle can be used to enforce the presence of javadoc. At least the Travis CI build executes checkstyle and fails if checkstyle fails. Am 05.09.2019 um 18:04 schrieb sebb: Can the CI build be changed to fail the build when Javadoc is omitted? On Thu, 5 Sep 2019 at 17:00, Gary Gregory

[CSV][CSV-251] CSVPrinter don't handle byte[] correctly for postgres

2019-09-05 Thread Gary Gregory
HI All: Please see https://issues.apache.org/jira/browse/CSV-251. I see the following options: (0) Do nothing, tell users to convert byte[] to String before calling the API. Lame but will work IMO. (1) Convert byte[] to a String using Apache Commons Codec's Hex class by telling it to do so

Re: [lang] Missing Javadocs

2019-09-05 Thread Gary Gregory
On Thu, Sep 5, 2019 at 12:10 PM sebb wrote: > Can the CI build be changed to fail the build when Javadoc is omitted? > Not that I found but I still added "javadoc:javadoc -Ddoclint=all" to GH builds to catch other mistakes. Gary > On Thu, 5 Sep 2019 at 17:00, Gary Gregory wrote: > > > > Hi

Re: [lang] Missing Javadocs

2019-09-05 Thread sebb
Can the CI build be changed to fail the build when Javadoc is omitted? On Thu, 5 Sep 2019 at 17:00, Gary Gregory wrote: > > Hi All: > > The following interfaces were added a while back without class-level > Javadoc: > > org.apache.commons.lang3.Functions.FailableBiConsumer Throwable> >

Re: [commons-lang] branch master updated: Javadoc nits.

2019-09-05 Thread sebb
On Thu, 5 Sep 2019 at 16:41, wrote: > > This is an automated email from the ASF dual-hosted git repository. > > ggregory pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/commons-lang.git > > > The following commit(s) were added to refs/heads/master by this

[lang] Missing Javadocs

2019-09-05 Thread Gary Gregory
Hi All: The following interfaces were added a while back without class-level Javadoc: org.apache.commons.lang3.Functions.FailableBiConsumer org.apache.commons.lang3.Functions.FailableBiFunction org.apache.commons.lang3.Functions.FailableBiPredicate

Re: [lang] org.apache.commons.text.lookup.IllegalArgumentExceptions to [lang].

2019-09-05 Thread Gilles Sadowski
Le jeu. 5 sept. 2019 à 17:37, Gary Gregory a écrit : > > On Thu, Sep 5, 2019 at 4:33 AM Gilles Sadowski wrote: > > > Le jeu. 5 sept. 2019 à 02:50, Gary Gregory a > > écrit : > > > > > > On Wed, Sep 4, 2019 at 4:51 PM Xeno Amess wrote: > > > > > > > Well, if you do think repeating the similar

Re: [lang] org.apache.commons.text.lookup.IllegalArgumentExceptions to [lang].

2019-09-05 Thread Gary Gregory
On Thu, Sep 5, 2019 at 4:33 AM Gilles Sadowski wrote: > Le jeu. 5 sept. 2019 à 02:50, Gary Gregory a > écrit : > > > > On Wed, Sep 4, 2019 at 4:51 PM Xeno Amess wrote: > > > > > Well, if you do think repeating the similar codes for 100+ times is > > > better than reflection and be more elegant

Re: [NOTICE] Introducing .asf.yaml for enhanced automation of git repository services

2019-09-05 Thread Gilles Sadowski
Hello. > -- Forwarded message - > De : Daniel Gruno > Date: jeu. 5 sept. 2019 à 02:32 > Subject: [NOTICE] Introducing .asf.yaml for enhanced automation of git > repository services > To: > > > Hello, fellow Apache committers and enthusiasts! > > Today, the Apache Infrastructure

Fwd: [NOTICE] Introducing .asf.yaml for enhanced automation of git repository services

2019-09-05 Thread Gilles Sadowski
Hi. [Forwarding the following message, so that the discussion can take place on the "dev" ML.] -- Forwarded message - De : Daniel Gruno Date: jeu. 5 sept. 2019 à 02:32 Subject: [NOTICE] Introducing .asf.yaml for enhanced automation of git repository services To: Hello, fellow

Re: [lang] org.apache.commons.text.lookup.IllegalArgumentExceptions to [lang].

2019-09-05 Thread sebb
I've just reviewed the PR, and I think it has a lot of issues (typos, wrong format types etc.) It also mixes different concerns. As such, I am -1 to the PR as it stands. I also don't think the new class adds any value. AFAICT all it does is allow one to drop the text 'new ' and 'String.'. (at

Re: [lang] org.apache.commons.text.lookup.IllegalArgumentExceptions to [lang].

2019-09-05 Thread Gilles Sadowski
Le jeu. 5 sept. 2019 à 02:50, Gary Gregory a écrit : > > On Wed, Sep 4, 2019 at 4:51 PM Xeno Amess wrote: > > > Well, if you do think repeating the similar codes for 100+ times is > > better than reflection and be more elegant or easier to read or > > something, then you can try maintain them. >