Re: [collections] Bloom filters

> On 18 Feb 2020, at 22:34, Gary Gregory wrote: > > On Tue, Feb 18, 2020 at 5:32 PM Claude Warren wrote: > >> Last one first, why a tree map? I think it is a holdover from an earlier >> implementation. It can be any reasonable Map (e.g. HashMap). >> >> on the remove() issue. You are abso

Re: [collections] Bloom filters

On Tue, Feb 18, 2020 at 5:32 PM Claude Warren wrote: > Last one first, why a tree map? I think it is a holdover from an earlier > implementation. It can be any reasonable Map (e.g. HashMap). > > on the remove() issue. You are absolutely correct, there is a bug. I > May you please add a test

Re: [collections] Bloom filters

Last one first, why a tree map? I think it is a holdover from an earlier implementation. It can be any reasonable Map (e.g. HashMap). on the remove() issue. You are absolutely correct, there is a bug. I looks like a partial edit got restored back into the code. The first block should be remov

Re: [collections] checkstyle

> On 18 Feb 2020, at 19:04, Gary Gregory wrote: > > At issue is that each Commons components has its own style and sometimes > its own custom Checkstyle configuration in its own location. My preference > is: > - Store a default Checkstyle, SpotBugs, JApiCmp, and JaCoCo configuration > in Common

Re: [collections] checkstyle

At issue is that each Commons components has its own style and sometimes its own custom Checkstyle configuration in its own location. My preference is: - Store a default Checkstyle, SpotBugs, JApiCmp, and JaCoCo configuration in Commons Parent under src/site/resources - Avoid bikeshedding for what

[collections] checkstyle

There have been a few PRs recently in collections with simple formatting errors. These should be picked up by checkstyle to prevent correction after merge. The [collections] checkstyle configuration is old. If I replace it with the Checkstyle version close to the Sun standard [1] then there ar

Re: [collections] Bloom filters

I've updated master with some of the fixes discussed. I've been looking through the rest of the BloomFilter code and the CountingBloomFilter appears to be broken: 1. When another CountingBloomFiler is merged or removed the counts of the other filter are ignored. This is not as documented. 2

Fwd: [math] Discuss: New feature MiniBatchKMeansClusterer

Hello. Le mar. 18 févr. 2020 à 04:49, 陈 涛 a écrit : > > Hi Gilles: > >I really do not know if anyone received my last mail, no one replay me for > a long time so I send it again and copy to you with another email system. Sorry for the delay. :-} > > > Some remarks: > > > * I didn't get why

Re: [collections] Bloom filters

On 18/02/2020 09:54, Claude Warren wrote: On Tue, Feb 18, 2020 at 9:12 AM Alex Herbert wrote: My maths is rusty. If A=0xF000ABCD as interpreted as an unsigned and B=0xF000ABCD but interpreted as a signed does (A mod N) = (B mod N) for all positive values of N? If so then you are correct

Re: [geometry] PMD failures

On 18/02/2020 03:06, Matt Juntunen wrote: Hi Alex, Thanks for the updates on this. FYI, the current geometry build fails due to a missing import: https://travis-ci.org/apache/commons-geometry/jobs/651768129#L3806. Hi, After a bit of fixing I have green lights on travis. I noticed that the t

Re: [collections] Bloom filters

On Tue, Feb 18, 2020 at 9:12 AM Alex Herbert wrote: > > My maths is rusty. If A=0xF000ABCD as interpreted as an unsigned and > > B=0xF000ABCD but interpreted as a signed does (A mod N) = (B mod N) for > all > > positive values of N? If so then you are correct and Signedness does not > > matte

Re: [collections] Bloom filters

> On 18 Feb 2020, at 08:02, Claude Warren wrote: > > On Mon, Feb 17, 2020 at 9:52 PM Alex Herbert > > wrote: > >> >> >>> On 17 Feb 2020, at 20:30, Claude Warren >> > wrote: >>> >>> Alex, >>> >>> Thank you for your comments. >>> >>

Re: [collections] Bloom filters

On Mon, Feb 17, 2020 at 9:52 PM Alex Herbert wrote: > > > > On 17 Feb 2020, at 20:30, Claude Warren wrote: > > > > Alex, > > > > Thank you for your comments. > > > > See comments inline. > > > > > > > > On Mon, Feb 17, 2020 at 3:20 PM Alex Herbert > > > wrote: >