Re: [math] Discuss: New feature MiniBatchKMeansClusterer

2020-02-25 Thread CT
Hi Gilles, -- Original -- From:"GillesSadowski"https://github.com/apache/commons-math/pull/120 Sorry for seemingly nit-picking but the global issue is the same as with PR #118: It contains too many unrelated changes. There should be *one* PR for each batch of

Re: [math] Discuss: New feature MiniBatchKMeansClusterer

2020-02-25 Thread CT
Hi, --Original-- From:"GillesSadowski"https://github.com/apache/commons-math/pull/120 Sorry for seemingly nit-picking but the global issue is the same as with PR #118: It contains too many unrelated changes. There should be *one* PR for each batch of significant

Re: [all] How PRs could be better

2020-02-25 Thread Amey Jadiye
We might need to develop a plugin to achieve this, and yes as Jochen mentioned this is just a scenario for bug fixes, not for new functionality and enhancements. 1. Plugin must-have functionality like sure-fire to execute the test cases. 2. Plugin must have the functionality to use git, so it can

Re: [math] Discuss: New feature MiniBatchKMeansClusterer

2020-02-25 Thread Gilles Sadowski
Hello. [Side question: Do you send a copy of your posts directly to me? If so, that is not necessary and is even annoying because when I hit "reply" in my mail client, the conversation continues off-list...] Le mar. 25 févr. 2020 à 14:53, CT a écrit : > > Hi Gilles: > Sorry for my unfamiliar

Re: [all] How PRs could be better

2020-02-25 Thread Jochen Wiedmann
I understand your intention, *if* the PR is a bug fix. But, what about the others? On Thu, Feb 20, 2020, 14:53 Gary Gregory wrote: > Hi All: > > I wonder if any of you have an ideas regarding the following. > > When looking at _some_ PRs (that are green on GitHub, build with tests and > other

Re: [math] Discuss: New feature MiniBatchKMeansClusterer

2020-02-25 Thread CT
Hi Gilles: Sorry for my unfamiliar in contribution. I started a new PR for most of your suggestion: https://github.com/apache/commons-math/pull/120 I remain have one question below: --Original-- From:"Gilles