回复: Re: [commons-compress] branch master updated: Update my(Peter Lee) personal information in pom

2020-03-16 Thread peterlee
Thank you! :) Lee On 2020/3/17 1:22:36, "Stefan Bodewig" wrote: welcome :-) Stefan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

回复: Re: [ANNOUNCE] Welcome Peter Lee (peterlee) as Apache Commons Committer

2020-03-16 Thread peterlee
Thank you all! It's a great honor to be a part of Apache. Peter Lee On 2020/3/17 2:42:01, "Woonsan Ko" wrote: Congrats and welcome, Peter! Woonsan On Mon, Mar 16, 2020 at 1:50 PM Gary Gregory wrote: Hi All, Please welcome Peter Lee (peterlee) as our latest Apache Commons Committer!

Re: [BloomFilters] changes to BloomFilter

2020-03-16 Thread Alex Herbert
Another item: ObjectsHashIterative is marked as Signedness.SIGNED. The computation is done using 32-bit integers. So the long output can be negative but the upper 32-bits are always either entirely 0 or entirely 1. I think this is a candidate for converting to an unsigned long and allowing it

Re: [BloomFilters] changes to BloomFilter

2020-03-16 Thread Alex Herbert
> On 16 Mar 2020, at 18:58, Claude Warren wrote: > > First I think that the hasher.getBits( Shape ) should be renamed to > iterator( Shape ). It was poorly named at the start. I can fix that. > > By definition a Hasher knows how many items it is going to insert. > > The Shape tells the

Re: [BloomFilters] changes to BloomFilter

2020-03-16 Thread Claude Warren
First I think that the hasher.getBits( Shape ) should be renamed to iterator( Shape ). It was poorly named at the start. By definition a Hasher knows how many items it is going to insert. The Shape tells the hasher how many hash functions to apply to each item. The Shape number of items is how

Re: [ANNOUNCE] Welcome Peter Lee (peterlee) as Apache Commons Committer

2020-03-16 Thread Woonsan Ko
Congrats and welcome, Peter! Woonsan On Mon, Mar 16, 2020 at 1:50 PM Gary Gregory wrote: > > Hi All, > > Please welcome Peter Lee (peterlee) as our latest Apache Commons Committer! > > Gary - To unsubscribe, e-mail:

Re: [BloomFilters] changes to BloomFilter

2020-03-16 Thread Alex Herbert
On 16/03/2020 07:57, Claude Warren wrote: I made a quick pass at changing getHasher() to iterator(). A look at the feasibility or have you started work on this? If so then I'll not start work on it as well. I changed master to return a boolean for the merge operations in BloomFilter. So

Re: [ANNOUNCE] Welcome Peter Lee (peterlee) as Apache Commons Committer

2020-03-16 Thread Rob Tompkins
Congrats Peter. Welcome! -Rob > On Mar 16, 2020, at 1:50 PM, Gary Gregory wrote: > > Hi All, > > Please welcome Peter Lee (peterlee) as our latest Apache Commons Committer! > > Gary - To unsubscribe, e-mail:

[ANNOUNCE] Welcome Peter Lee (peterlee) as Apache Commons Committer

2020-03-16 Thread Gary Gregory
Hi All, Please welcome Peter Lee (peterlee) as our latest Apache Commons Committer! Gary

Re: [commons-compress] branch master updated: Update my(Peter Lee) personal information in pom

2020-03-16 Thread Stefan Bodewig
welcome :-) Stefan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [BloomFilters] changes to BloomFilter

2020-03-16 Thread Claude Warren
I made a quick pass at changing getHasher() to iterator(). I think we can get rid of HasherBloomFilter as its purpose was really to create a Bloom filter for temporary usage and it doesn't seem to be required if we have a hasher that can be created from a Shape and a function that creates an