Re: [IO] Using file filters with Java NIO file tree walking

Had a look at the commit [1] and found no issues. Really impressive work Gary. You've updated the code and also added a lot of examples in the Javadocs. Really golden. I used simple code snippets to understand how the new API works, and quickly test it locally. But will try to update

Re: [VOTE] Release Apache Commons Net 3.7.2 based on RC1

  [x] +1 Release these artifacts Built from tag with Maven 3.5.4 and Java 8. Build passing OK, reports look good. Checked signatures, found no issues. Inspected some files in binary/source folders of the dist area, all looking good. Thanks for managing this release Gary. Bruno On

Re: JUnit assertAll and assertThrows question

For my money: - I REALLY like assertThrows - Might as well go to JUnit 5 if you feel up for it. - BUT: My biggest pain point ATM is that while Commons VFS is on JUnit 4, most tests are still JUnit 3 (TestCase) classes that won't run properly from Eclipse. So I would really like help getting VFS

Re: JUnit assertAll and assertThrows question

Hi John, Would be +1 from me if: 1. It does not require to move from junit4 to junit5 (no gain IMHO) 2. Test goes further than a Exception rule or @Test(expected) If both points are matched it makes sense to me, otherwise it will likely add more issues from my experience. Le mer. 14 oct. 2020

JUnit assertAll and assertThrows question

before i waste time looking at upgrading tests... any objections if i upgrade tests to use assertAll and assertThrows introduced in JUnit jupiter? I see it as less tech debt removal and I'm happy to spend time doing the upgrade which I've done from maybe several projects now. Just don't want to

[VOTE] Release Apache Commons Net 3.7.2 based on RC1

We have fixed a few bugs since Apache Commons Net 3.7.1 was released, so I would like to release Apache Commons Net 3.7.2. Apache Commons Net 3.7.2 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/net/3.7.2-RC1 (svn revision 41933) The Git tag

Dependabot pr's

to shortcut multiple people telling me not to manually raise pr's to upgrade dependencies, and dependabot is the preferred option for commons to be raising these upgrades, and i should raise a pr to enable dependabot. so... here are all the pr's to enable dependabot on the repo's which lack a

.gitignore commons-chain

hi, is someone able to review this pr please. https://github.com/apache/commons-chain/pull/3 It's the last commons project that doesn't have a .gitignore file. My other pr's adding a .gitignore have either been merged or someone noticed and added one themselves. cheers, john

Re: [compress] BZip2CompressorInputStream stops working without rhyme or reason ...

I don't know what could there apaprently be exactly at byte offset 2848 in some buffer but files reporing to be fine by bzip2 --test can't be processed by BZip2CompressorInputStream: ~ $

Re: [compress] BZip2CompressorInputStream stops working without rhyme or reason ...

the files decompress fine using Linux bzip2: $ time bzip2 --decompress --verbose --keep "enwiki-20200920-pages-articles-multistream1.xml-p1p41242.bz2" enwiki-20200920-pages-articles-multistream1.xml-p1p41242.bz2: done real2m22.089s user2m6.664s sys 0m7.184s $ time bzip2