Re: [VOTE] Release Apache Commons Daemon 1.2.4 based on RC2

2021-01-20 Thread Gary Gregory
+1 Building package from src zip. SHA512 ok. Same environment for me as RC1, double checked I could build Windows binaries. Apache RAT check ok JapiCmp ok Gary On Wed, Jan 20, 2021, 11:04 Rob Tompkins wrote: > Reviewed. All looks good. > > +1 > > Cheers, > -Rob > > > On Jan 20, 2021, at

Re: [geometry] IO Modules

2021-01-20 Thread Matt Juntunen
Hi Gilles, I've updated the PR with the new module/package names. > I don't see the link between "(not) extensible" and "enum": Extensibility is > provided by API (which classes are public and meant to be reused, e.g. by > custom IO code) while the "enum" defines the file formats that are

Re: [geometry] IO Modules

2021-01-20 Thread Gilles Sadowski
Le mer. 20 janv. 2021 à 22:42, Matt Juntunen a écrit : > > Hi Gilles, > > > package "io" does not belong in "core". > > Ah, yes. I'd like to keep the core and euclidean IO modules separate since > I'm picturing a spherical IO module later on down the road. In that case, > perhaps we could just

Re: [geometry] IO Modules

2021-01-20 Thread Matt Juntunen
Hi Gilles, > package "io" does not belong in "core". Ah, yes. I'd like to keep the core and euclidean IO modules separate since I'm picturing a spherical IO module later on down the road. In that case, perhaps we could just put the "io" portion of the module/package name before everything

Re: [VOTE] Release Apache Commons Daemon 1.2.4 based on RC2

2021-01-20 Thread Rob Tompkins
Reviewed. All looks good. +1 Cheers, -Rob > On Jan 20, 2021, at 10:52 AM, Mark Thomas wrote: > > On 18/01/2021 17:12, Mark Thomas wrote: >> We have fixed a couple of bugs and a regression in 1.2.3, so I would >> like to release Apache Commons Daemon 1.2.4. > > > >> Please review the

Re: [VOTE] Release Apache Commons Daemon 1.2.4 based on RC2

2021-01-20 Thread Mark Thomas
On 18/01/2021 17:12, Mark Thomas wrote: > We have fixed a couple of bugs and a regression in 1.2.3, so I would > like to release Apache Commons Daemon 1.2.4. > Please review the release candidate and vote. > This vote will close no sooner that 72 hours from now. > > [X] +1 Release these

Re: [geometry] IO Modules

2021-01-20 Thread Gilles Sadowski
Hi Matt. Le mer. 20 janv. 2021 à 05:03, Matt Juntunen a écrit : > > Hello, > > I've created GEOMETRY-115 and an associated PR [1] containing new modules for > IO functionality. The new modules are > > * commons-geometry-core-io - Common space-independent interfaces and > classes > *

Re: [All][Math] New GA component

2021-01-20 Thread Gilles Sadowski
Hello. Le mer. 20 janv. 2021 à 11:11, Avijit Basak a écrit : > > Hello Gilles Sadowski > > Thanks for your reply. Yes I intend to contribute to enhancement > of the GA functionality as per the JIRA (MATH-1563) proposal. My proposal was to first create a new component (and, thus,

Re: [All][Math] New GA component

2021-01-20 Thread Avijit Basak
Hello Gilles Sadowski Thanks for your reply. Yes I intend to contribute to enhancement of the GA functionality as per the JIRA (MATH-1563) proposal. If I find any other changes suitable I would also propose the same. Could you kindly look into the approval process for this JIRA. Thanks