Re: [geometry] IO Modules

2021-01-21 Thread Matt Juntunen
Hi Gilles, > Really, the main point is to separate format (contents) from filename > (container). This makes sense. What would you think of the approach below? This would separate the format name from the file extension(s) and provide an enum containing default format information and

Re: [IOUtils] Possible bug in contentEquals(InputStream input1, InputStream input2)

2021-01-21 Thread Alex Herbert
You are looping over the streams twice. If you add an assertion error message you will find the failure is on the second iteration of the loop where the two streams on the second pass are equal as they both have no bytes left. You must take care to close your InputStreams after each use and

Re: [VOTE][RESULT] Release Apache Commons Daemon 1.2.4 based on RC2

2021-01-21 Thread Mark Thomas
The following votes were cast: Binding: +1: kinow, markt, chtompki, ggregory No other votes were cast. The vote therefore passes. Thanks to everyone who contributed toward this release. Mark - To unsubscribe, e-mail:

[IO] release

2021-01-21 Thread Gary Gregory
Hi all, I think we are pretty close to a release candidate. I might cut one soon. Gary

[IOUtils] Possible bug in contentEquals(InputStream input1, InputStream input2)

2021-01-21 Thread Singleton, Andrew (SanTech)
Hi, I was testing comparing some small input streams, looping through a list to see if a stream was already present and I got unexpected results. The bug can be recreated simply @Test void testCompare() throws Exception { byte[] b1 = new byte[]{'a','b','c'}; byte[] b2 = new

Re: [geometry] IO Modules

2021-01-21 Thread Gilles Sadowski
Hello. Le mer. 20 janv. 2021 à 23:55, Matt Juntunen a écrit : > > Hi Gilles, > > I've updated the PR with the new module/package names. > > > I don't see the link between "(not) extensible" and "enum": Extensibility > > is provided by API (which classes are public and meant to be reused, e.g.