Re: [numbers][gsoc] GSoC 2022 - NUMBERS-186 Proposal

2022-07-05 Thread Sumanth Rajkumar
Thanks for the feedback Alex, > Not a problem. Just write a dedicated method for Complex and a generic > method in ComplexFunctions. This small level of code duplication is > acceptable where the efficiency of the method is greatly improved by > rewriting it, as has been done for the scalar functi

Re: [collections] Recording the BloomFilter package in changes

2022-07-05 Thread Gilles Sadowski
Hi. Le mar. 5 juil. 2022 à 14:54, Alex Herbert a écrit : > > Claude is currently working through changes to the Bloom filter package. > There are a number of Jira tickets for each change. However this is > unreleased code and so I believe we do not have to put them all in the > changes.xml. I ag

[collections] Recording the BloomFilter package in changes

2022-07-05 Thread Alex Herbert
Claude is currently working through changes to the Bloom filter package. There are a number of Jira tickets for each change. However this is unreleased code and so I believe we do not have to put them all in the changes.xml. Currently there is only this entry: BloomFilter contribution.

Re: [numbers][gsoc] GSoC 2022 - NUMBERS-186 Proposal

2022-07-05 Thread Alex Herbert
On Mon, 4 Jul 2022 at 23:00, Sumanth Rajkumar wrote: > Thanks Alex for PR feedback. > I have incorporated the majority of the requested changes to the PR. > > I would like to discuss the remaining points here. > > > In > > commons-numbers-complex/src/main/java/org/apache/commons/numbers/complex/C