Re: [IO] 2 Patches for SymbolicLinkFileFilter

2023-04-18 Thread Miguel Muñoz
Today I resubmitted both changes as Pull Requests. — Miguel Muñoz On Tue, Apr 18, 2023 at 3:44 AM Gary Gregory wrote: > Thanks Miguel, > > Please provide changes as PRs on GiHub. This is the best way to go IMO > because it runs code against all tests on all configured OSs and Java > versions,

Re: [IO] IO-769: FileUtils copyDirectory() should not use COPY_ATTRIBUTES #377

2023-04-18 Thread Gary D. Gregory
Merged https://github.com/apache/commons-io/pull/377, see the PR for behavior. For the upcoming 2.12.0, COPY_ATTRIBUTES is no longer used by default. Gary On 2023/04/17 12:27:09 Gary Gregory wrote: > Hi All, > > I would like to get some ideas and consensus on how to proceed with >

Re: [IO] 2 Patches for SymbolicLinkFileFilter

2023-04-18 Thread Gary Gregory
Thanks Miguel, Please provide changes as PRs on GiHub. This is the best way to go IMO because it runs code against all tests on all configured OSs and Java versions, and provides the least friction for managing changes. TY! Gary On Tue, Apr 18, 2023, 04:20 Miguel Muñoz wrote: > Developers, >

Re: [IO] 2 Patches for SymbolicLinkFileFilter

2023-04-18 Thread Bruno Kinoshita
> > Or as a Github PR: > +1 On Tue, 18 Apr 2023 at 11:18, sebb wrote: > Or as a Github PR: > > https://github.com/apache/commons-io/pulls > > These systems are easier for developers to track than emails, which > can get overlooked. > > On Tue, 18 Apr 2023 at 09:54, Gilles Sadowski > wrote: >

Re: [IO] 2 Patches for SymbolicLinkFileFilter

2023-04-18 Thread sebb
Or as a Github PR: https://github.com/apache/commons-io/pulls These systems are easier for developers to track than emails, which can get overlooked. On Tue, 18 Apr 2023 at 09:54, Gilles Sadowski wrote: > > Hi. > > Le mar. 18 avr. 2023 à 10:20, Miguel Muñoz a écrit : > > > > Developers, > > >

Re: [IO] 2 Patches for SymbolicLinkFileFilter

2023-04-18 Thread Gilles Sadowski
Hi. Le mar. 18 avr. 2023 à 10:20, Miguel Muñoz a écrit : > > Developers, > > (I'm new to Apache, Welcome. > so I hope this is the right way to submit patches.) The usual way would be to file a report on the bug-tracking system: https://issues.apache.org/jira/projects/IO and upload patches

[IO] 2 Patches for SymbolicLinkFileFilter

2023-04-18 Thread Miguel Muñoz
Developers, (I'm new to Apache, so I hope this is the right way to submit patches.) Here are two patches, which must be applied in order. The first one fixes bugs in the file, and adds a method that will facilitate testing. The second one is a thorough unit test that handles issues on Windows