lang

2023-06-29 Thread Dimitrios Efthymiou
Hello. I am a new contributor. Say I am working on a new public method for a class, say, ExceptionUtils.java. What value do I put in the @since field in the JavaDoc of this method? Thank you for your time

Re: [VOTE] Release Apache Commons Pool 2.12.0 based on RC1

2023-06-29 Thread Phil Steitz
On Thu, Jun 29, 2023 at 11:39 AM Gary Gregory wrote: > Great presentation in the video Elliotte. Thanks for sharing the link. > +1 many thanks. Now back to our hero. Let me pretend to be one of the people in the audience of the video. We have this library that is used by all kinds of

Re: [VOTE] Release Apache Commons Pool 2.12.0 based on RC1

2023-06-29 Thread Gary Gregory
Great presentation in the video Elliotte. Thanks for sharing the link. Gary On Thu, Jun 29, 2023, 10:33 Elliotte Rusty Harold wrote: > On Thu, Jun 29, 2023 at 10:10 AM Gilles Sadowski > wrote: > > > > Le jeu. 29 juin 2023 à 15:22, Elliotte Rusty Harold > > a écrit : > > > > > > On Thu, Jun

Re: [VOTE] Release Apache Commons Pool 2.12.0 based on RC1

2023-06-29 Thread Elliotte Rusty Harold
On Thu, Jun 29, 2023 at 11:43 AM Gilles Sadowski wrote: > I think I can understand your rationale: Something that can be > corrected at runtime should be signalled by a checked exception. > Right? No, not at all. Recoverability is **not** the distinction between checked and unchecked

Re: [io] Possible addition of getFiles/getFileNames and Ant includes/excludes

2023-06-29 Thread Gary Gregory
On my end, I'll make sure IO filters can interoperate with PathMatchers if they don't already... Gary On Thu, Jun 29, 2023, 09:10 Elliotte Rusty Harold wrote: > On Thu, Jun 29, 2023 at 8:12 AM Gary Gregory > wrote: > > > > On Thu, Jun 29, 2023 at 7:20 AM Elliotte Rusty Harold > > wrote: > >

Re: [VOTE] Release Apache Commons Pool 2.12.0 based on RC1

2023-06-29 Thread Gilles Sadowski
Le jeu. 29 juin 2023 à 17:42, Elliotte Rusty Harold a écrit : > > On Thu, Jun 29, 2023 at 10:48 AM Gilles Sadowski wrote: > > > The situation is recoverable from the caller's POV, by performing a > > *new* call, with a correct argument. We certainly don't need a special > > kind of exception[1]

Re: [VOTE] Release Apache Commons Pool 2.12.0 based on RC1

2023-06-29 Thread Gilles Sadowski
Le jeu. 29 juin 2023 à 16:33, Elliotte Rusty Harold a écrit : > > On Thu, Jun 29, 2023 at 10:10 AM Gilles Sadowski wrote: > > > > Le jeu. 29 juin 2023 à 15:22, Elliotte Rusty Harold > > a écrit : > > > > > > On Thu, Jun 29, 2023 at 9:07 AM Gilles Sadowski > > > wrote: > > > > > > > > Hello. >

Re: [VOTE] Release Apache Commons Pool 2.12.0 based on RC1

2023-06-29 Thread Elliotte Rusty Harold
On Thu, Jun 29, 2023 at 10:48 AM Gilles Sadowski wrote: > The situation is recoverable from the caller's POV, by performing a > *new* call, with a correct argument. We certainly don't need a special > kind of exception[1] to handle this situation. What's wrong with catching > a

Re: [VOTE] Release Apache Commons Pool 2.12.0 based on RC1

2023-06-29 Thread Gilles Sadowski
Le jeu. 29 juin 2023 à 16:18, Gary Gregory a écrit : > > > I never could find a convincing example of "recoverable conditions". > > Really? How about typing in a bad server name, user name, or password? Unfortunately we use different definitions of "recoverable". IMO, they are typically

Re: [VOTE] Release Apache Commons Pool 2.12.0 based on RC1

2023-06-29 Thread Elliotte Rusty Harold
On Thu, Jun 29, 2023 at 10:10 AM Gilles Sadowski wrote: > > Le jeu. 29 juin 2023 à 15:22, Elliotte Rusty Harold > a écrit : > > > > On Thu, Jun 29, 2023 at 9:07 AM Gilles Sadowski > > wrote: > > > > > > Hello. > > > > > > Le jeu. 29 juin 2023 à 14:44, Gary Gregory a > > > écrit : > > > > > I

Re: [VOTE] Release Apache Commons Pool 2.12.0 based on RC1

2023-06-29 Thread Gary Gregory
> I never could find a convincing example of "recoverable conditions". Really? How about typing in a bad server name, user name, or password? That's a classic recoverable exception (in JDBC land for example). Gary On Thu, Jun 29, 2023, 10:11 Gilles Sadowski wrote: > Le jeu. 29 juin 2023 à

Re: [VOTE] Release Apache Commons Pool 2.12.0 based on RC1

2023-06-29 Thread Gilles Sadowski
Le jeu. 29 juin 2023 à 15:22, Elliotte Rusty Harold a écrit : > > On Thu, Jun 29, 2023 at 9:07 AM Gilles Sadowski wrote: > > > > Hello. > > > > Le jeu. 29 juin 2023 à 14:44, Gary Gregory a écrit > > : > > > I agree with the second part assuming the *current* Java > > best practices, not

Re: [VOTE] Release Apache Commons Pool 2.12.0 based on RC1

2023-06-29 Thread Elliotte Rusty Harold
On Thu, Jun 29, 2023 at 9:07 AM Gilles Sadowski wrote: > > Hello. > > Le jeu. 29 juin 2023 à 14:44, Gary Gregory a écrit : > I agree with the second part assuming the *current* Java > best practices, not because of old APIs that are here to stay > only because of infinite backwards

Re: [io] Possible addition of getFiles/getFileNames and Ant includes/excludes

2023-06-29 Thread Elliotte Rusty Harold
On Thu, Jun 29, 2023 at 8:12 AM Gary Gregory wrote: > > On Thu, Jun 29, 2023 at 7:20 AM Elliotte Rusty Harold > wrote: > I'm not sure what you are proposing. Adding a new filter to IO that > behaves like Ant? Adding a new filter to IO that behaves like Python? > Are Ant and Python expressions

Re: [VOTE] Release Apache Commons Pool 2.12.0 based on RC1

2023-06-29 Thread Gilles Sadowski
Hello. Le jeu. 29 juin 2023 à 14:44, Gary Gregory a écrit : > [...] > > Java makes a clear distinction between checked and unchecked > exceptions. As a mid-level API, I do not feel Pool should take a > design POV that is different from Java's intended pattern regarding > exceptions. I agree

Re: [io] Possible addition of getFiles/getFileNames and Ant includes/excludes

2023-06-29 Thread Slawomir Jaranowski
It is common pattern called globstar, eg from https://en.wikipedia.org/wiki/Glob_(programming): globstar: allows ** on its own as a name component to recursively match any number of layers of non-hidden directories.[10] Also supported by the JS libraries and Python's glob. so it is not only an

Re: [VOTE] Release Apache Commons Pool 2.12.0 based on RC1

2023-06-29 Thread Gary Gregory
Thanks for digging in Mark (more below which will just echo my reply to Phil). On Thu, Jun 29, 2023 at 5:43 AM Mark Thomas wrote: > > On 28/06/2023 14:16, Gary Gregory wrote: > > Hi All and Phil. > > I haven't been that involved in Pool recently but Pool remains a key > dependency for Tomcat

Re: [VOTE] Release Apache Commons Pool 2.12.0 based on RC1

2023-06-29 Thread Gary Gregory
On Wed, Jun 28, 2023 at 5:26 PM Phil Steitz wrote: > > On Wed, Jun 28, 2023 at 6:17 AM Gary Gregory wrote: > > > Hi All and Phil. > > > > Thank you for the thoughtful reply, Phil. > > > > The main driver here was two combine keeping binary compatibility > > _and_ benefit call sites of the API by

Re: [io] Possible addition of getFiles/getFileNames and Ant includes/excludes

2023-06-29 Thread Gary Gregory
On Thu, Jun 29, 2023 at 7:20 AM Elliotte Rusty Harold wrote: > > On Mon, Jun 19, 2023 at 8:17 PM Gary Gregory wrote: > > > I like the general idea of adding configurable include and exclude features. > > > > I am uncertain about baking in the Ant-specific pattern formats in > > Commons IO.

Re: [VOTE] Release Apache Commons Pool 2.12.0 based on RC1

2023-06-29 Thread Gilles Sadowski
Hello. [Sorry to continue a discussion that should probably go in its own thread.] Le jeu. 29 juin 2023 à 11:43, Mark Thomas a écrit : > > On 28/06/2023 14:16, Gary Gregory wrote: > > Hi All and Phil. > > I haven't been that involved in Pool recently but Pool remains a key > dependency for

Re: [io] Possible addition of getFiles/getFileNames and Ant includes/excludes

2023-06-29 Thread Elliotte Rusty Harold
On Mon, Jun 19, 2023 at 8:17 PM Gary Gregory wrote: > I like the general idea of adding configurable include and exclude features. > > I am uncertain about baking in the Ant-specific pattern formats in > Commons IO. Allowing the include and exclude feature to be provided > through some

Re: [VOTE] Release Apache Commons Pool 2.12.0 based on RC1

2023-06-29 Thread Mark Thomas
On 28/06/2023 14:16, Gary Gregory wrote: Hi All and Phil. I haven't been that involved in Pool recently but Pool remains a key dependency for Tomcat (via DBCP). The main driver here was two combine keeping binary compatibility _and_ benefit call sites of the API by _not_ having to catch