+1
Tested src zip, SHA512 OK, ASC OK.
- Maven default goal OK
- macOS Java 17 build of jsvc OK (from ./configure setup)
- Windows Java 17 build OK for both EXEs.
Note: Compiler WARNINGs:
arguments.c:453:5: warning: switch condition has boolean value [-Wswitch-bool]
switch (par) {
^
I am canceling this vote thread to incorporate Claude's idea. It is
indeed simpler and clearer :-) I had to look at the code as a whole in
Eclipse to better appreciate the whole picture.
Gary
On Sat, May 18, 2024 at 12:52 PM Claude Warren wrote:
>
> I would be OK with not making the additional
We have fixed a few bugs since Apache Commons Compress 1.26.1 was
released, so I would like to release Apache Commons Compress 1.26.2.
Apache Commons Compress 1.26.2 RC1 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/compress/1.26.2-RC1
(svn revision 69274)
The
I would be OK with not making the additional method public.
On Sat, May 18, 2024 at 3:38 PM Gary Gregory wrote:
> Thank you Claude.
>
> I'm OK either way. I've commented on the PR. I'd like to know what others
> think.
>
> The change proposed only makes sense if we cancel this RC othewise it
>
Hi Gary,
Looks like I missed adding them before I committed the changes. I've
just done that.
Mark
On 18/05/2024 15:28, Gary Gregory wrote:
Hi Mark,
Thank you for preparing this release candidate.
There are no SHA512 files in:
Hi Mark,
Thank you for preparing this release candidate.
There are no SHA512 files in:
https://dist.apache.org/repos/dist/dev/commons/daemon/1.4.0-RC1/source/
https://dist.apache.org/repos/dist/dev/commons/daemon/1.4.0-RC1/binaries/
Gary
On Fri, May 17, 2024 at 2:06 PM Mark Thomas wrote:
>
>
Thank you Claude.
I'm OK either way. I've commented on the PR. I'd like to know what others think.
The change proposed only makes sense if we cancel this RC othewise it
would be a breaking change or would clutter up the API with an
additional public method.
Gary
On Sat, May 18, 2024 at 9:04 AM
-1 There is a design issue.
The HelpFormatter now takes a BiFunction to
format the description for deprecated Options. However, it is simple to
implement Function instead. I think this makes for a cleaner
interface. Since this interface is public facing, I would like to merge
the change in
If we are changing the Javadoc settings, we should update the footer
to include the full list of attributions.
On Sat, 18 May 2024 at 12:59, Emmanuel Bourg wrote:
>
> Le 18/05/2024 à 13:07, Gary Gregory a écrit :
> > You must be talking about this:
> >
> >
Le 18/05/2024 à 13:07, Gary Gregory a écrit :
You must be talking about this:
https://bugs.openjdk.org/browse/JDK-8202961
The frames command line option might be completely gone from the current
Java version but I haven't tried
Digging a bit, frames were deprecated in JDK 11 and eventually
The "unknown unknowns" ;-)
Gary
On Sat, May 18, 2024 at 7:27 AM Emmanuel Bourg wrote:
>
> The search box is a nice addition, but it's only useful if you know what
> you are looking for. It doesn't replace a plain list of classes that can
> be explored at a glance.
>
> Emmanuel Bourg
>
> Le
The search box is a nice addition, but it's only useful if you know what
you are looking for. It doesn't replace a plain list of classes that can
be explored at a glance.
Emmanuel Bourg
Le 18/05/2024 à 13:09, Gary Gregory a écrit :
Notice that the newer Javadocs has a fancy Search box, quite
Notice that the newer Javadocs has a fancy Search box, quite handy IMO.
Gary
On Sat, May 18, 2024, 7:07 AM Gary Gregory wrote:
> You must be talking about this:
>
> https://bugs.openjdk.org/browse/JDK-8202961
>
> The frames command line option might be completely gone from the current
> Java
You must be talking about this:
https://bugs.openjdk.org/browse/JDK-8202961
The frames command line option might be completely gone from the current
Java version but I haven't tried
:
https://docs.oracle.com/en/java/javase/21/docs/specs/man/javadoc.html#option-add-stylesheet
Note that the no
Hi all,
I got a look at the Commons IO Javadoc [1] yesterday and it looks like
something got wrong starting with the 2.14 release, the framed layout
[2] up to the version 2.13 was much more usable, with an instant
overview of the package structure and the classes available. Exploring
the API
The code in the implementation of the EnhancedDoubleHasher is based on the
wikipedia article https://en.wikipedia.org/wiki/Double_hashing.
The code that appears in the article is:
struct key; /// Opaque
/// Use other data types when needed. (Must be unsigned for guaranteed
wrapping.)
extern
Tracking this with:
https://issues.apache.org/jira/browse/COLLECTIONS-855
On Sat, 18 May 2024 at 08:26, Alex Herbert wrote:
> Thanks for highlighting this. I did not use the original paper and based
> the implementation on Wikipedia.
>
> I think the issue is that we use i in [0, k); we can
Thanks for highlighting this. I did not use the original paper and based
the implementation on Wikipedia.
I think the issue is that we use i in [0, k); we can correct this by using
i in [1, k]. The order inside the loop would not change but we would have
to decrement i to use in the assignment
Gary,
I just realized this AM that there is a change I proposed to simplify the
deprecated output. Please see pull request 277. I think the change from
BiFormat to Format makes the HelpFormatter API much cleaner.
Claude
On Fri, May 17, 2024 at 6:26 PM Claude Warren wrote:
> Gary,
>
> I
The code in the implementation of the EnhancedDoubleHasher is based on the
wikipedia article https://en.wikipedia.org/wiki/Double_hashing.
The code that appears in the article is:
struct key; /// Opaque
/// Use other data types when needed. (Must be unsigned for guaranteed
wrapping.)
extern
20 matches
Mail list logo
