[GitHub] commons-rdf issue #43: COMMONSRDF-49: Make AbstractRDFParser serializable

2017-11-13 Thread afs
Github user afs commented on the issue: https://github.com/apache/commons-rdf/pull/43 All I did was point out that it isn't logically serializable at all points in its usage. My suggestion is that there is design with a builder (serializable) and instance (not seriali

[GitHub] commons-rdf issue #43: COMMONSRDF-49: Make AbstractRDFParser serializable

2017-11-03 Thread afs
Github user afs commented on the issue: https://github.com/apache/commons-rdf/pull/43 AbstractRDFParser is stateful at some points in its lifecycle - input stream and the threadpool/futures. Is this mixing a builder for the configuration, where serialization makes sense

[GitHub] commons-rdf issue #43: COMMONSRDF-49: Make AbstractRDFParser serializable

2017-11-03 Thread afs
Github user afs commented on the issue: https://github.com/apache/commons-rdf/pull/43 Relaying a question from sebb on the JIRA: https://issues.apache.org/jira/browse/COMMONSRDF-49#comment-16236065 including pointing out the long term restriction that comes with it

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

2017-10-30 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/42#discussion_r147701690 --- Diff: jena/src/test/java/org/apache/commons/rdf/jena/DatasetJenaTest.java --- @@ -7,7 +7,7 @@ * "License"); you may not use this file

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

2017-10-30 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/42#discussion_r147701840 --- Diff: jena/src/main/java/org/apache/commons/rdf/jena/impl/JenaDatasetImpl.java --- @@ -149,7 +149,7 @@ public long size() { @Override

[GitHub] commons-rdf issue #32: COMMONSRDF-55: Handle Jena's urn:x-arq:DefaultGraph a...

2017-02-03 Thread afs
Github user afs commented on the issue: https://github.com/apache/commons-rdf/pull/32 I haven't looked at the code in enough detail but I was assuming there would be one place with two functions: Quad->JenaQuad and JenaQuad->Quad. This would the strategy (policy) for

[GitHub] commons-rdf issue #32: COMMONSRDF-55: Handle Jena's urn:x-arq:DefaultGraph a...

2017-02-02 Thread afs
Github user afs commented on the issue: https://github.com/apache/commons-rdf/pull/32 `defaultGraph` is explicit name of the default graph in Jena, `defaultGraphNode` is for when the system is generating it, not for data. There are methods for "is this the default graph?&

[GitHub] commons-rdf issue #30: COMMONSRDF-51 language tags compared lower case

2017-01-24 Thread afs
Github user afs commented on the issue: https://github.com/apache/commons-rdf/pull/30 You mean you tried to Graph.delete a triple? That deletes exact triples (.equals). Graph.remove deletes triples that match (same value) by using "find" that has the value-matching

[GitHub] commons-rdf issue #30: COMMONSRDF-51 language tags compared lower case

2017-01-21 Thread afs
Github user afs commented on the issue: https://github.com/apache/commons-rdf/pull/30 RDF 1.1 mentions: 1. Turtle parsing - there is a lang tag rule. 2. The text that conversion to a lowercase lexical is allowed. 3. Value-comparison is case insensitive. Which

[GitHub] commons-rdf issue #30: COMMONSRDF-51 language tags compared lower case

2017-01-16 Thread afs
Github user afs commented on the issue: https://github.com/apache/commons-rdf/pull/30 @ansell mentions one of the reasons the wording for RDF 1.1is not so direct - RDF 1.0 did not sanction the common normalization defined in BCP47 canonicalization, although that actually requires