Re: [CSV] Extract interfaces?

2013-03-25 Thread Jörg Schaible
Gary Gregory wrote: On Sat, Mar 23, 2013 at 8:59 AM, Thomas Neidhart thomas.neidh...@gmail.comwrote: On 03/23/2013 12:41 PM, Benedikt Ritter wrote: Hi, while looking through the code, I was asking myself why we expose implementation classes. Wouldn't it be better to extract

Re: [CSV] Extract interfaces?

2013-03-25 Thread Benedikt Ritter
2013/3/25 Jörg Schaible joerg.schai...@gmx.de Gary Gregory wrote: On Sat, Mar 23, 2013 at 8:59 AM, Thomas Neidhart thomas.neidh...@gmail.comwrote: On 03/23/2013 12:41 PM, Benedikt Ritter wrote: Hi, while looking through the code, I was asking myself why we expose

Re: [CSV] Extract interfaces?

2013-03-25 Thread Emmanuel Bourg
Le 23/03/2013 12:41, Benedikt Ritter a écrit : WDYT? Benedikt -1, this is overly complicated for such a simple component. I once wished we could design something simple and elegant, but it seems the wind is blowing in another direction, so I'll just give up. Emmanuel Bourg smime.p7s

Re: [CSV] Extract interfaces?

2013-03-24 Thread Adrian Crum
On 3/23/2013 12:59 PM, Thomas Neidhart wrote: On 03/23/2013 12:41 PM, Benedikt Ritter wrote: Hi, while looking through the code, I was asking myself why we expose implementation classes. Wouldn't it be better to extract interfaces from CSVParser, CSVPrinter and CSVRecord? At least for the

Re: [CSV] Extract interfaces?

2013-03-24 Thread Simone Tripodi
I agree. Interfaces would make sense if you expected to have many different implementations. +1 http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/

Re: [CSV] Extract interfaces?

2013-03-24 Thread Gary Gregory
On Sat, Mar 23, 2013 at 8:59 AM, Thomas Neidhart thomas.neidh...@gmail.comwrote: On 03/23/2013 12:41 PM, Benedikt Ritter wrote: Hi, while looking through the code, I was asking myself why we expose implementation classes. Wouldn't it be better to extract interfaces from CSVParser,

[CSV] Extract interfaces?

2013-03-23 Thread Benedikt Ritter
Hi, while looking through the code, I was asking myself why we expose implementation classes. Wouldn't it be better to extract interfaces from CSVParser, CSVPrinter and CSVRecord? At least for the CSVRecord it would make sense because users cannot create CSVRecord instances. Why binding them to a

Re: [CSV] Extract interfaces?

2013-03-23 Thread Thomas Neidhart
On 03/23/2013 12:41 PM, Benedikt Ritter wrote: Hi, while looking through the code, I was asking myself why we expose implementation classes. Wouldn't it be better to extract interfaces from CSVParser, CSVPrinter and CSVRecord? At least for the CSVRecord it would make sense because users