Re: [Compress] COMPRESS-540 : Random access of tar

2020-11-17 Thread Peter Lee
Agree. Seems this random access was achieved with a new class TarFile and it won't have effects on existing apps. Tars are designed to be a sequence access format so a random access would cost more time. I'm just curious how much do we want to have a random access here? I mean, do we always

Re: [Compress] COMPRESS-540 : Random access of tar

2020-11-16 Thread Gary Gregory
Reading in everything to allow for random access should be something I have to turn on explicitly, using a new parameter/API. IOW, existing apps should not have to pay the price for a feature they don't want. Think of an app that looks at large tar... Gary On Sun, Nov 15, 2020, 21:51 Peter Lee

Re: [Compress] COMPRESS-540 : Random access of tar

2020-11-15 Thread Peter Lee
Thanks Bruno. This helps a lot. :) cheers, Lee On 11 16 2020, at 1:45 , Bruno P. Kinoshita wrote: > Hi Lee, > I don't know much about Compress' API, only as a user of the API in some > projects. > I had a cursory look, read comments and JIRA and left comments on GitHub PR. > No blockers for

Re: [Compress] COMPRESS-540 : Random access of tar

2020-11-15 Thread Bruno P. Kinoshita
Hi Lee, I don't know much about Compress' API, only as a user of the API in some projects. I had a cursory look, read comments and JIRA and left comments on GitHub PR. No blockers for me. Hope it helps. Thanks for bringing it to the mailing list, and for the review. CheersBruno On Monday,

[Compress] COMPRESS-540 : Random access of tar

2020-11-15 Thread Peter Lee
Hi all, Robin has pushed a PR in github in July that implemented the random access of tar : https://github.com/apache/commons-compress/pull/113 It's achieved by reading the tar once and have the start position of each tar entry stored. Tar is not designed to be random accessed so this may be a