Re: [Geometry] Checked exceptions

2021-07-25 Thread Matt Juntunen
I've created GEOMETRY-138 [1] to track this and discuss the technical details. -Matt [1] https://issues.apache.org/jira/projects/GEOMETRY/issues/GEOMETRY-138 On Sat, Jul 24, 2021 at 12:41 PM Gilles Sadowski wrote: > > Le sam. 24 juil. 2021 à 18:25, Matt Juntunen > a écrit : > > > > I don't

Re: [Geometry] Checked exceptions

2021-07-24 Thread Gilles Sadowski
Le sam. 24 juil. 2021 à 18:25, Matt Juntunen a écrit : > > I don't have a preference for checked or unchecked exceptions. I just > want it to be consistent, easy to use, and maintainable. Checked exceptions are a maintenance nightmare. [Some time in the future, you change the implementation so

Re: [Geometry] Checked exceptions

2021-07-24 Thread Gary Gregory
Note that the JRE provides UncheckedIOException. Gary On Sat, Jul 24, 2021, 12:25 Matt Juntunen wrote: > I don't have a preference for checked or unchecked exceptions. I just > want it to be consistent, easy to use, and maintainable. With that > said, what specific changes are you picturing

Re: [Geometry] Checked exceptions

2021-07-24 Thread Matt Juntunen
I don't have a preference for checked or unchecked exceptions. I just want it to be consistent, easy to use, and maintainable. With that said, what specific changes are you picturing should be made to the code here? Are you suggesting a geometry-specific exception type? Should we wrap IOExceptions

Re: [Geometry] Checked exceptions

2021-07-24 Thread Gilles Sadowski
Hi. Le sam. 24 juil. 2021 à 17:01, Matt Juntunen a écrit : > > Hello, > > > AFAICT, a precondition (max string length) is violated by the input: the > error is the caller's fault (either passing a too long string, or not having > set an appropriate upper bound). > > This is not correct. This

Re: [Geometry] Checked exceptions

2021-07-24 Thread Matt Juntunen
Hello, > AFAICT, a precondition (max string length) is violated by the input: the error is the caller's fault (either passing a too long string, or not having set an appropriate upper bound). This is not correct. This exception is thrown when a string token from the input stream exceeds the

[Geometry] Checked exceptions

2021-07-24 Thread Gilles Sadowski
Hello. Somehow I missed that [Geometry] contains usage of checked exceptions. As mentioned in other threads, I have a hard time conceiving that the kind of codes we are dealing with here ever needs the concept of checked exception (in its intended usage per the _current_ Java experts, and not