Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-collections/pull/29
Sorry about that. :(
But the correct parameter order part of you pull request is still relevant.
It would be nice if you could create a new rebased pull request for
Github user vamsi-kavuri commented on the issue:
https://github.com/apache/commons-collections/pull/29
@PascalSchumacher I am late by an hour. Decimal separators are added by
gregory
https://github.com/apache/commons-collections/commit/641aa1c663ebead0189bf001a06ee56463070ddb
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-collections/pull/29
Thanks! Looking forward to the pull request!
---
-
To unsubscribe, e-mail:
Github user vamsi-kavuri commented on the issue:
https://github.com/apache/commons-collections/pull/29
@PascalSchumacher Thanks for the feedback. I haven't thought of german
locale. good catch. I will update it in a different PR.
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-collections/pull/29
`assertEquals(MapUtils.getDouble(in,"key", 0.0), 2.0, 0);` etc. should be
`assertEquals(2.0, MapUtils.getDouble(in,"key", 0.0), 0);` because it is
`assertEquals(double expected,
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-collections/pull/29
Thanks!
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail:
Github user coveralls commented on the issue:
https://github.com/apache/commons-collections/pull/29
[](https://coveralls.io/builds/13678056)
Coverage increased (+1.5%) to 86.616% when pulling
