Github user bodewig commented on the issue:
https://github.com/apache/commons-compress/pull/33
Thanks a lot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/33
[](https://:/builds/12010056)
Coverage increased (+0.4%) to 84.713% when pulling
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-compress/pull/33
Link to the pull request: https://github.com/apache/commons-compress/pull/35
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-compress/pull/33
@bodewig
Thank you for your kind response!
Really appreciate that!
Therefore I've made all the changes you requested/proposed.
And of course added myself as a
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/33
[](https://:/builds/12008449)
Coverage increased (+0.3%) to 84.673% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/33
[](https://:/builds/12008341)
Coverage increased (+0.3%) to 84.673% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/33
[](https://:/builds/12007847)
Coverage increased (+0.5%) to 84.812% when pulling
Github user bodewig commented on the issue:
https://github.com/apache/commons-compress/pull/33
Thanks @TheRealHaui
I agree with your comment on
`ChecksumCalculatingInputStreamTest#testGetValueThrowsNullPointerException`
this looks like a bug. So I'd rather remove the test
Github user bodewig commented on the issue:
https://github.com/apache/commons-compress/pull/33
Fortunately I'm not the only one who could merge this :-)
More seriously, it may take a bit of time until I get there, but I will.
---
If your project is set up for it, you can
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/33
[](https://:/builds/11957412)
Coverage increased (+0.2%) to 84.524% when pulling
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-compress/pull/33
@bodewig
Could you be so kind an review my contribution and - of course - most of
all pull it into the code base.
---
If your project is set up for it, you can reply to this email
11 matches
Mail list logo
