Github user rpreissel commented on the pull request:
https://github.com/apache/commons-compress/pull/11#issuecomment-197507339
This is a memory issue and from my point of view there is no simple way to
test it with an unit test.
I have tried to write an unit test and used
Github user asfgit closed the pull request at:
https://github.com/apache/commons-compress/pull/11
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user rpreissel opened a pull request:
https://github.com/apache/commons-compress/pull/11
Bugfix for COMPRESS-343
The class ...sevenz.Coders.DeflateDecoder does not close (end()) the
Deflater and Inflater. This can lead to native memory issues: see
Github user garydgregory commented on the pull request:
https://github.com/apache/commons-compress/pull/11#issuecomment-197425393
Hi,
Thank you for the patch.
Do you have a unit test that show the problem and it being fixed by the
patch?
Gary
---
If your
Github user bodewig commented on the pull request:
https://github.com/apache/commons-compress/pull/11#issuecomment-197788653
I had naively assumed `InflaterInputStream#close` would free up the
resources. Come to think of it, if we pass in the `Inflater` ourselves it makes
sense that
Github user rpreissel commented on the pull request:
https://github.com/apache/commons-compress/pull/11#issuecomment-197554132
I added tests with PowerMock/Mockito.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user garydgregory commented on the pull request:
https://github.com/apache/commons-compress/pull/11#issuecomment-197518791
Yes, one of:
- Use Mockito or Powermock to assert that the end() method has been called
(best)
- add an isClosed method somewhere that sets an
