Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/32
I've added javadoc to this effect (commit 7bbff25) and will merge this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/32
Note that option (2) would also add potential inconsistency between Commons
RDF `.getGraphName().isPresent()` and `asJenaQuad().isDefaultGraph()`, which is
unfortunate, but only in that
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/32
I guess it's a question of where we put the "inconsistency" barrier. We can
probably assume that in the odd case that `urn:x-arq:DefaultGraph` appear
literally in a non-Jena `IRI` or a non-Jena
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/32
The thing is a Commons RDF `JenaQuad` has in a way two feet into Jena - the
underlying Jena `Quad` as well as the underlying `Node` instances (which would
be wrapped as `RDFTerm` instances).
Github user afs commented on the issue:
https://github.com/apache/commons-rdf/pull/32
I haven't looked at the code in enough detail but I was assuming there
would be one place with two functions: Quad->JenaQuad and JenaQuad->Quad. This
would the strategy (policy) for all of the
Github user ajs6f commented on the issue:
https://github.com/apache/commons-rdf/pull/32
I suppose I incline to (2) right now. The "magic" URIs are entirely
Jena-specific, so ideally they appear as few places outside of Jena code itself
as possible. On the other hand,
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/32
The Commons RDF marker for the default graph (as of today) is
`Optional.empty()` and not an `RDFNode` (and thus can only be used in the
`Quad.getGraphName()` position).
There are four
Github user afs commented on the issue:
https://github.com/apache/commons-rdf/pull/32
`defaultGraph` is explicit name of the default graph in Jena,
`defaultGraphNode` is for when the system is generating it, not for data.
There are methods for "is this the default graph?" that
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/32
Any comments from perhaps @afs or @ajs6f? I'm not sure exactly at what
boundary we should replace `` and friends with
`Optional.empty()` -- in the solution of this PR it happens for any Quad
