[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...

2017-06-15 Thread chtompki
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/45 I believe the reason that we're getting a "success" to be the fact that the `docker` command exits with a 0. So might we want to do a `{docker run -v `pwd`:/work library/ibmjava:8-sdk /bin/bash

[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...

2017-06-15 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/45 The build failure I quoted occurs after the findbugs exceptions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...

2017-06-15 Thread ameyjadiye
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/45 Hi @PascalSchumacher , where did you see build is failing ? I see all builds passed given in your link https://travis-ci.org/apache/commons-text/jobs/243003865, Yes ibmjdk8 is runni

[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...

2017-06-14 Thread chtompki
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/45 Hm. I'll give this a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...

2017-06-14 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/45 I guess this failure is also the reason that the coveralls integration is broken. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...

2017-06-14 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/45 This does not seem to really work. It looks like ibm jdk build is run after each (oracle8, openjdk(7|8)) build and actually fails, but the build is still marked successful, e.g.:

[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...

2017-06-11 Thread chtompki
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/45 Agreed. Will pull this in tonight or in the morning (UTC-4) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...

2017-06-11 Thread ameyjadiye
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/45 @chtompki, I think we are good to merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...

2017-06-09 Thread ameyjadiye
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/45 Created one image containing maven with ibmjava8, same can be pushed to apache dockerhub repo https://hub.docker.com/r/ameyjadiye/ibmjava8/ --- If your project is set up for it, you

[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...

2017-06-09 Thread joehni
Github user joehni commented on the issue: https://github.com/apache/commons-text/pull/45 In Maven "verify" implies "test", since "verify" is a later step in the Maven [build lifecycle](http://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#Build_Lifecycle_Basi

[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...

2017-06-09 Thread ameyjadiye
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/45 Hi @garydgregory , I think removing ``` test ``` is not good idea, better we can have ```verify``` along with ```test``` --- If your project is set up for it, you can reply to this email and

[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...

2017-06-08 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/45 [![Coverage Status](https://coveralls.io/builds/11892865/badge)](https://coveralls.io/builds/11892865) Coverage remained the same at 96.653% when pulling **90b5426b33476d091b19eb

[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...

2017-06-08 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/45 [![Coverage Status](https://coveralls.io/builds/11892865/badge)](https://coveralls.io/builds/11892865) Coverage remained the same at 96.653% when pulling **90b5426b33476d091b19eb