[GitHub] commons-text issue #70: partial automated migration to assertj

2017-10-27 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/70 [![Coverage Status](https://coveralls.io/builds/13921641/badge)](https://coveralls.io/builds/13921641) Coverage remained the same at 98.298% when pulling

[GitHub] commons-text issue #70: partial automated migration to assertj

2017-10-27 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/70 [![Coverage Status](https://coveralls.io/builds/13921641/badge)](https://coveralls.io/builds/13921641) Coverage remained the same at 98.298% when pulling

[GitHub] commons-text issue #70: partial automated migration to assertj

2017-10-27 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/70 [![Coverage Status](https://coveralls.io/builds/13921430/badge)](https://coveralls.io/builds/13921430) Coverage remained the same at 98.298% when pulling

[GitHub] commons-text issue #70: partial automated migration to assertj

2017-10-27 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/70 [![Coverage Status](https://coveralls.io/builds/13916156/badge)](https://coveralls.io/builds/13916156) Coverage remained the same at 98.298% when pulling

[GitHub] commons-text issue #70: partial automated migration to assertj

2017-10-22 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/70 @chtompki What do you think? --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional

[GitHub] commons-text issue #70: partial automated migration to assertj

2017-10-22 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/70 Sure. AssertJ 2.x for java 7 and 3.x for java 8 have been developed in parallel for a few years (and currently still are). Java 7 compatible changes are done in 2.x and then merged

[GitHub] commons-text issue #70: partial automated migration to assertj

2017-10-20 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-text/pull/70 I thought we were using Java 8, but [text] is actually using Java 7. I thought there was some discussion around the minimum requirement for the latest version of assertj being Java 8? So I assume

[GitHub] commons-text issue #70: partial automated migration to assertj

2017-10-20 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-text/pull/70 Looks good to me. Given [text] is already on Java 8, I believe it's a good candidate to start using assertj. >The script use only the most basic assertj assertions, so the full power is

[GitHub] commons-text issue #70: partial automated migration to assertj

2017-10-15 Thread britter
Github user britter commented on the issue: https://github.com/apache/commons-text/pull/70 Good idea. It's always better to discuss with some acutal code examples at hands. --- - To unsubscribe, e-mail:

[GitHub] commons-text issue #70: partial automated migration to assertj

2017-10-15 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/70 >Cool! Have missed the discussion about introducing this for Text. I like it. These was no discussion yet. I just thought I do a quick prototype with a component after the

[GitHub] commons-text issue #70: partial automated migration to assertj

2017-10-15 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/70 [![Coverage Status](https://coveralls.io/builds/13722459/badge)](https://coveralls.io/builds/13722459) Coverage remained the same at 98.238% when pulling

[GitHub] commons-text issue #70: partial automated migration to assertj

2017-10-15 Thread britter
Github user britter commented on the issue: https://github.com/apache/commons-text/pull/70 Cool! Have missed the discussion about introducing this for Text. I like it. --- - To unsubscribe, e-mail: