[GitHub] commons-text issue #79: Upgrade to JUnit 5.1

2018-04-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/79 Great! @kinow Thanks in-depth check! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For

[GitHub] commons-text issue #79: Upgrade to JUnit 5.1

2018-04-08 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/commons-text/pull/79 Comitted! :-) Works for me as well in Eclipse 4.7.3. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org

[GitHub] commons-text issue #79: Upgrade to JUnit 5.1

2018-04-08 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-text/pull/79 ![screenshot_2018-04-08_22-34-52](https://user-images.githubusercontent.com/304786/38466438-1d71ec6e-3b7d-11e8-82e2-d21cfa9e79bd.png) Screenshot with Eclipse version, and sample output

[GitHub] commons-text issue #79: Upgrade to JUnit 5.1

2018-04-08 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-text/pull/79 Tested the master branch first, and everything obviously worked. Then switched to this branch, and got an error message, then Eclipse opened the run configuration. Followed

[GitHub] commons-text issue #79: Upgrade to JUnit 5.1

2018-04-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/79 JUnit 5 should work with any Eclipse Version released during the last year (as long as you delete existing run configurations for the project). @garydgregory Can you give

[GitHub] commons-text issue #79: Upgrade to JUnit 5.1

2018-04-04 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/79 The only problem I encountered was that I had to delete the existing JUnit run configurations for commons-text (I'm using Eclipse Oxygen.3 and it does not seem to be able to update a

[GitHub] commons-text issue #79: Upgrade to JUnit 5.1

2018-04-04 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/commons-text/pull/79 Hi Pascal! Thank you for the PR. My only hesitation with JUnit 5 is that it does not work in Eclipse yet, for me at least. ---

[GitHub] commons-text issue #79: Upgrade to JUnit 5.1

2018-04-04 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/79 [![Coverage Status](https://coveralls.io/builds/16348620/badge)](https://coveralls.io/builds/16348620) Coverage remained the same at 97.83% when pulling