My vote: +1 (binding)
Verified:
+1 sha512 sha256
+1 asc / KEYS
+1 src zip vs tar.gz
+1 bin zip vs tar.gz vs jar
+1 src vs git (missing in src: README.md CONTRIBUTING.md;
whitespace differences in commons-daemon-1.2.0-native-src)
+1 mvn repo vs dist
+1 mvn
+1, thanks for the release!
Jon
On Fri, Jun 28, 2019 at 3:21 PM Mark Thomas wrote:
> It has been ~18 months since the last Commons Daemon release. After the
> recent flurry of activity and a couple of failed RCs, it is time for
> another release vote.
>
> Notable changes since 1.1.0 include:
>
+1, reports good, signatures good, agree with Gary on builds.
-Rob
> On Jun 28, 2019, at 10:20 AM, Mark Thomas wrote:
>
> It has been ~18 months since the last Commons Daemon release. After the
> recent flurry of activity and a couple of failed RCs, it is time for
> another release vote.
>
>
On 28/06/2019 15:20, Mark Thomas wrote:
> [X] Approved - go ahead and release Commons Daemon 1.2.0 RC2 as 1.2.0
> [ ] Broken - do not release because...
Tested with Tomcat 9.0.x build process and the resulting Windows installer.
There were (expected) file permission issues due to the change
On Fri, Jun 28, 2019 at 11:37 AM Mark Thomas wrote:
> On 28/06/2019 15:49, Gary Gregory wrote:
> > +1
> >
> > TODO later: Update RNs since the POM uses version "1.2.0" and the release
> > notes use "1.2".
>
> That is by design. The release notes are intended for the entire 1.2.x
> release
On 28/06/2019 15:49, Gary Gregory wrote:
> +1
>
> TODO later: Update RNs since the POM uses version "1.2.0" and the release
> notes use "1.2".
That is by design. The release notes are intended for the entire 1.2.x
release stream. This is how Daemon has done it in the past.
Do we want to switch
+1
TODO later: Update RNs since the POM uses version "1.2.0" and the release
notes use "1.2".
TODO later: src\native\windows\README should have a file extension since on
Windows text files without extensions are not customary.
TODO later: Fix Javadocs for Java 11 with 'mvn -V clean install
It has been ~18 months since the last Commons Daemon release. After the
recent flurry of activity and a couple of failed RCs, it is time for
another release vote.
Notable changes since 1.1.0 include:
- Improved JRE/JDK detection to support increased range of both JVM
versions and vendors.
-
