[CANCEL] Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC1

Ah, thanks for the suggestion. RC2 vote coming soon. > On Jan 8, 2020, at 5:52 AM, Rob Tompkins wrote: > > > >> On Jan 8, 2020, at 8:31 AM, Gary Gregory > > wrote: >> >> You should reply to this thread with [CANCEL] in the subject to make it >> clear this VOTE i

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC1

> On Jan 8, 2020, at 8:31 AM, Gary Gregory wrote: > > You should reply to this thread with [CANCEL] in the subject to make it > clear this VOTE is canceled. Yes…good call. > > Gary > > On Wed, Jan 8, 2020 at 8:30 AM Gary Gregory wrote: > >> On Tue, Jan 7, 2020 at 12:12 AM Carl Hall wrot

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC1

You should reply to this thread with [CANCEL] in the subject to make it clear this VOTE is canceled. Gary On Wed, Jan 8, 2020 at 8:30 AM Gary Gregory wrote: > On Tue, Jan 7, 2020 at 12:12 AM Carl Hall wrote: > >> Thanks for the reviews, Gary and Bruno. And thanks, Gary, for giving such >> a sh

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC1

On Tue, Jan 7, 2020 at 12:12 AM Carl Hall wrote: > Thanks for the reviews, Gary and Bruno. And thanks, Gary, for giving such > a sharp eye to the broader range of code. I'll work through the suggestions > in this thread, and clear everything up for the next RC. > Good news :-) Gary > > > > On

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC1

Thanks for the reviews, Gary and Bruno. And thanks, Gary, for giving such a sharp eye to the broader range of code. I'll work through the suggestions in this thread, and clear everything up for the next RC. > On Jan 6, 2020, at 8:21 AM, Gary Gregory wrote: > > I think we need a development pa

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC1

I think we need a development pass before we release. I see too many resource leaks under certain conditions. For example: Calling org.apache.commons.dbutils.QueryRunner.batch(String, Object[][]) with a null String or a null Object[][] will leak JDBC Connections. This should be fixed by followin

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC1

Hi Carl, The Javadocs need cleaning up: There are {@inheritDoc} where none should be. Gary On Sun, Jan 5, 2020 at 2:13 AM Carl Hall wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons DbUtils 1.7 was released, so I would like to release > Apa

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC1

Carl, Release notes should and announcements must contain a link to the download page. I use the release notes as the text for the announcement email to hit 2 birds with one stone. IOW, add this to the bottom of each release notes section: Download page: https://commons.apache.org/proper/commons

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC1

Thanks Gary. @Carl, I think it might be better to prepare a new release? FWIW, I tested on JDK 13 Ubuntu LTS, and it built successfully. And the reports look good too (checkstyle went down from 591 to 4!). So I think everything else in this RC looked fine. Cheers Bruno On Monday, 6 Januar

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC1

Nice find! I’ve added a commit to address this, but will wait a bit for more review before cutting RC2. > On Jan 5, 2020, at 5:04 AM, Gary Gregory wrote: > > Good find Bruno! That a blocker IMO, simple to fix at least. I should have > time to review over the next day or so. > > Gary > > On Su

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC1

Good find Bruno! That a blocker IMO, simple to fix at least. I should have time to review over the next day or so. Gary On Sun, Jan 5, 2020 at 4:49 AM Bruno P. Kinoshita wrote: > Hi, > > > Not sure if a blocker, but the NOTICE.txt files need the 2019 -> 2020 > update. Will have time to review

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC1

Hi, Not sure if a blocker, but the NOTICE.txt files need the 2019 -> 2020 update. Will have time to review this one tomorrow NZ time I think. CheersBruno On Sunday, 5 January 2020, 8:13:51 pm NZDT, Carl Hall wrote: We have fixed quite a few bugs and added some significant enhancem

[VOTE] Release Apache Commons DbUtils 1.8 based on RC1

We have fixed quite a few bugs and added some significant enhancements since Apache Commons DbUtils 1.7 was released, so I would like to release Apache Commons DbUtils 1.8. Apache Commons DbUtils 1.8 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbutils/1.8