Re: [VOTE] Release Compress 1.5 based on RC1

2013-03-13 Thread Jörg Schaible
+1, builds fine from source and tests run with all my Java runtime environments. Stefan Bodewig wrote: > Hi all, > > [took me a few days longer since I wanted to incorporate fixes for the > two issues that popped up last week. So here we go.] > > With 30 JIRA issues fixed it is about time to

Re: [VOTE] Release Compress 1.5 based on RC1

2013-03-12 Thread Benedikt Ritter
2013/3/12 sebb > On 11 March 2013 21:18, Benedikt Ritter wrote: > > Hello Stefan, > > > > 2013/3/11 Stefan Bodewig > > > >> Hi all, > >> > >> [took me a few days longer since I wanted to incorporate fixes for the > >> two issues that popped up last week. So here we go.] > >> > >> With 30 JIRA

[compress] Missing Files in Source Distribution (was Re: [VOTE] Release Compress 1.5 based on RC1)

2013-03-11 Thread Stefan Bodewig
On 2013-03-11, Benedikt Ritter wrote: > I've noticed, that the src archives differ from the RC tag. The following > files are missing: > .gitattributes > .gitignore > doap_compress.rdf > PROPOSAL.txt > Is this intended? In a way, yes. They are not listed inside the assembly descriptor. The .gi

Re: [VOTE] Release Compress 1.5 based on RC1

2013-03-11 Thread Stefan Bodewig
On 2013-03-11, Gary Gregory wrote: > - Some (maybe not all) of the PMD/CPD issues seems easy to fix At least the CPD one looks easier than it is - it uses a lot of variables that are mutated and used outside of the block. Many of the PMDs have reasons as well like overriding equals when not doin

[compress] Since and Implemented Interfaces (was Re: [VOTE] Release Compress 1.5 based on RC1)

2013-03-11 Thread Stefan Bodewig
On 2013-03-11, sebb wrote: > Minor nit: the addition of "implements Serializable" to ZipLong, > ZipShort and ZipEightBightInteger is not documented in the Javadoc. Is there a formal way to document "implements Foo since 1.5" other than free form text in a class level comment? I'd like to add it

Re: [VOTE] Release Compress 1.5 based on RC1

2013-03-11 Thread sebb
On 11 March 2013 21:18, Benedikt Ritter wrote: > Hello Stefan, > > 2013/3/11 Stefan Bodewig > >> Hi all, >> >> [took me a few days longer since I wanted to incorporate fixes for the >> two issues that popped up last week. So here we go.] >> >> With 30 JIRA issues fixed it is about time to cut a

Re: [VOTE] Release Compress 1.5 based on RC1

2013-03-11 Thread Benedikt Ritter
Hello Stefan, 2013/3/11 Stefan Bodewig > Hi all, > > [took me a few days longer since I wanted to incorporate fixes for the > two issues that popped up last week. So here we go.] > > With 30 JIRA issues fixed it is about time to cut a new release of > Commons Compress. > > Tarballs: > htt

Re: [VOTE] Release Compress 1.5 based on RC1

2013-03-11 Thread sebb
On 11 March 2013 08:57, Stefan Bodewig wrote: > Hi all, > > [took me a few days longer since I wanted to incorporate fixes for the > two issues that popped up last week. So here we go.] > > With 30 JIRA issues fixed it is about time to cut a new release of > Commons Compress. > > Tarballs: >

Re: [VOTE] Release Compress 1.5 based on RC1

2013-03-11 Thread Gary Gregory
+1 but with some non-showstoppers of note: - I see some nice little fixes Sebb's has committed that would make the release nicer. - Some (maybe not all) of the PMD/CPD issues seems easy to fix Tested the SVN tag with: Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 08:5

Re: [VOTE] Release Compress 1.5 based on RC1

2013-03-11 Thread Stefan Bodewig
>> http://svn.apache.org/viewvc/commons/proper/compress/tags/COMPRESS-1.5_RC1/ On 2013-03-11, Gary Gregory wrote: > The tag is wrong, it is: > http://svn.apache.org/repos/asf/commons/proper/compress/tags/COMPRESS-1.5_RC1 Right. I copy-pasted the example vote mail from the compress site and it a

Re: [VOTE] Release Compress 1.5 based on RC1

2013-03-11 Thread Gary Gregory
The tag is wrong, it is: http://svn.apache.org/repos/asf/commons/proper/compress/tags/COMPRESS-1.5_RC1 Gary On Mon, Mar 11, 2013 at 4:57 AM, Stefan Bodewig wrote: > Hi all, > > [took me a few days longer since I wanted to incorporate fixes for the > two issues that popped up last week. So her

[VOTE] Release Compress 1.5 based on RC1

2013-03-11 Thread Stefan Bodewig
Hi all, [took me a few days longer since I wanted to incorporate fixes for the two issues that popped up last week. So here we go.] With 30 JIRA issues fixed it is about time to cut a new release of Commons Compress. Tarballs: http://people.apache.org/~bodewig/cc-1.5/ Maven artifacts a