[digester] Should popping the last object off the stack update the root?

2015-01-02 Thread Barney
Hi, There seems to me to be a bit of a discrepancy between the way push() and pop() interact with the root object when stack actions are used to change the object. * If a stack action changes the root object when being pushed onto the stack then the root reference is set to the changed

Re: [digester] Should popping the last object off the stack update the root?

2015-01-02 Thread Benedikt Ritter
Hello Barney, thanks for the report. The normal way for contributing code is by attaching a patch to jira [1]. Don't forget to include some unit tests ;-) TIA! Benedikt [1] https://issues.apache.org/jira 2015-01-02 12:26 GMT+01:00 Barney b002...@bsxl.com: Hi, There seems to me to be a bit

Re: [digester] Should popping the last object off the stack update the root?

2015-01-02 Thread Benedikt Ritter
2015-01-02 21:29 GMT+01:00 Barney b002...@bsxl.com: Thanks Benedikt, I'll put a patch together and submit a JIRA. The main reason I didn't do that the first time was I wasn't sure if this idea had already been considered and rejected for some reason, so I thought I'd just check here first.

Re: [digester] Should popping the last object off the stack update the root?

2015-01-02 Thread Barney
Thanks Benedikt, I'll put a patch together and submit a JIRA. The main reason I didn't do that the first time was I wasn't sure if this idea had already been considered and rejected for some reason, so I thought I'd just check here first. Cheers,