Re: [vfs] webdav4 extending http4 provider?

2019-03-06 Thread Woonsan Ko
Hi Gary, I forgot to ask: I ended up copying the test data files and test class files (in src/test/resources/test-data and src/test/java/code/) from the core to commons-vfs-jackrabbit3. Is there a good way to avoid duplicates? I didn't choose Maven dependency plugin's unpack as it requires 'packa

Re: [vfs] webdav4 extending http4 provider?

2019-03-06 Thread Woonsan Ko
Hi Gary, I've created a pull request: https://github.com/apache/commons-vfs/pull/52 But it's just for early-review purpose, not ready for merging yet, mainly because it depends on Jackrabbit 2.19.2-SNAPSHOT at the moment. I'll merge my PR [1] to Jackrabbit myself, and I will need to wait for cutti

Re: [vfs] webdav4 extending http4 provider?

2019-02-25 Thread Woonsan Ko
On Mon, Feb 25, 2019 at 9:28 AM Gary Gregory wrote: > > Stepping back, It seems to me we have two paths: > - Update Jackrabbit transparently and open ourselves up to _potential_ > compatibility issues. > - Do it the way we did for HttpCore 3 to 4 (which is what we are talking > about here.) > > Wh

Re: [vfs] webdav4 extending http4 provider?

2019-02-25 Thread Gary Gregory
Stepping back, It seems to me we have two paths: - Update Jackrabbit transparently and open ourselves up to _potential_ compatibility issues. - Do it the way we did for HttpCore 3 to 4 (which is what we are talking about here.) What about this: - Instead of adding code to the sandbox, create a new

Re: [vfs] webdav4 extending http4 provider?

2019-02-25 Thread Woonsan Ko
On Mon, Feb 25, 2019 at 8:07 AM Gary Gregory wrote: > > On Sun, Feb 24, 2019 at 4:00 PM Woonsan Ko wrote: > > > On Mon, Feb 18, 2019 at 2:09 PM Woonsan Ko wrote: > > > > > > On Mon, Feb 18, 2019 at 1:45 PM Gary Gregory > > wrote: > > > > > > > > Hi Woonsan, > > > > > > > > Why disable existing

Re: [vfs] webdav4 extending http4 provider?

2019-02-25 Thread Gary Gregory
On Sun, Feb 24, 2019 at 4:00 PM Woonsan Ko wrote: > On Mon, Feb 18, 2019 at 2:09 PM Woonsan Ko wrote: > > > > On Mon, Feb 18, 2019 at 1:45 PM Gary Gregory > wrote: > > > > > > Hi Woonsan, > > > > > > Why disable existing tests? > > > > I think the new Jackrabbit dependency 2.19.x would conflict

Re: [vfs] webdav4 extending http4 provider?

2019-02-24 Thread Woonsan Ko
On Mon, Feb 18, 2019 at 2:09 PM Woonsan Ko wrote: > > On Mon, Feb 18, 2019 at 1:45 PM Gary Gregory wrote: > > > > Hi Woonsan, > > > > Why disable existing tests? > > I think the new Jackrabbit dependency 2.19.x would conflict with the > old one, 1.6.5. > Jackrabbit upgraded httpclient dependency

Re: [vfs] webdav4 extending http4 provider?

2019-02-18 Thread Woonsan Ko
On Mon, Feb 18, 2019 at 1:45 PM Gary Gregory wrote: > > Hi Woonsan, > > Why disable existing tests? I think the new Jackrabbit dependency 2.19.x would conflict with the old one, 1.6.5. Jackrabbit upgraded httpclient dependency to 4.x since 2.16.0 with no changes in maven coordinates nor package n

Re: [vfs] webdav4 extending http4 provider?

2019-02-18 Thread Gary Gregory
Hi Woonsan, Why disable existing tests? Gary On Mon, Feb 18, 2019, 13:19 Woonsan Ko Hi, > > I'm trying to create a PR as a fix to VFS-686. > At first, I've tried to fix those in > org.apache.commons.vfs2.provider.webdav package, but realized that the > changes will break API compatibility. For

[vfs] webdav4 extending http4 provider?

2019-02-18 Thread Woonsan Ko
Hi, I'm trying to create a PR as a fix to VFS-686. At first, I've tried to fix those in org.apache.commons.vfs2.provider.webdav package, but realized that the changes will break API compatibility. For example, WebdavFileSystemConfigBuilder#getInstance() can't be supported as-is obviously. So, I t