Hi.
Le jeu. 15 oct. 2020 à 17:29, Alex Herbert a écrit :
>
>
>
> > On 15 Oct 2020, at 15:56, John Patrick wrote:
> >
> > <— snip -->
> >
> > Will look at vfs and maybe also rng regarding tidying up the tests etc.
>
> Did you mean ’tidying up math’?
>
> Regarding RNG, [...]
I fully concur with
It's been a minor struggle to get components to Java 8, despite my efforts.
Java 11 is a ways off especially since not all platforms support it yet
(IBM iSeries IIRC, which matters to me).
I'm all for getting all of Commons to Java 8.
Gary
On Thu, Oct 15, 2020, 10:57 John Patrick wrote:
>
> On 15 Oct 2020, at 15:56, John Patrick wrote:
>
> <— snip -->
>
> Will look at vfs and maybe also rng regarding tidying up the tests etc.
Did you mean ’tidying up math’?
Regarding RNG, the test suite relies on the fact that statistical tests can
fail and be rerun. This uses a feature in
Circa 2016 or 2017 I was trying to get commons projects ready for java
9, so trying to get Automatic-Module-Name added into the manifest.
Moved onto other non commons projects for 2018 and 2019, helped with
modules and jupiter upgrades.
End of 2019 most of the java 9 work on other projects was
Hello.
Le mer. 14 oct. 2020 à 21:41, John Patrick a écrit :
>
> before i waste time looking at upgrading tests...
>
> any objections if i upgrade tests to use assertAll and assertThrows
> introduced in JUnit jupiter?
>
> I see it as less tech debt removal and I'm happy to spend time doing
> the
Looking at commons-collections, commons-digester and commons-validator
at the moment.
Will look at commons-vfs next regarding getting to JUnit v4, then
adding assertThrows afterwards.
What are views about adding
`1.8`? I've not
done it at the moment as suspect builds are not setup for that and
For my money:
- I REALLY like assertThrows
- Might as well go to JUnit 5 if you feel up for it.
- BUT: My biggest pain point ATM is that while Commons VFS is on JUnit 4,
most tests are still JUnit 3 (TestCase) classes that won't run properly
from Eclipse.
So I would really like help getting VFS
Hi John,
Would be +1 from me if:
1. It does not require to move from junit4 to junit5 (no gain IMHO)
2. Test goes further than a Exception rule or @Test(expected)
If both points are matched it makes sense to me, otherwise it will likely
add more issues from my experience.
Le mer. 14 oct. 2020
before i waste time looking at upgrading tests...
any objections if i upgrade tests to use assertAll and assertThrows
introduced in JUnit jupiter?
I see it as less tech debt removal and I'm happy to spend time doing
the upgrade which I've done from maybe several projects now. Just
don't want to
