Re: commons-testing git commit: Add SecurityManagerTestRule from Apache Log4j.

2018-03-01 Thread Gary Gregory
On Thu, Mar 1, 2018 at 3:57 PM, Bernd Eckenfels wrote: > Good Rule Gary, > > I wonder: do we have a convention for fields? Order might not be so > important if you use IDEs, but when reviewing patches or pull requests I > still prefer to have my fields at the beginning of

Re: commons-testing git commit: Add SecurityManagerTestRule from Apache Log4j.

2018-03-01 Thread Bernd Eckenfels
Good Rule Gary, I wonder: do we have a convention for fields? Order might not be so important if you use IDEs, but when reviewing patches or pull requests I still prefer to have my fields at the beginning of a class. Gruss Bernd Gruss Bernd -- http://bernd.eckenfels.net