Also, I think that further cleanup is possible (cf. wantu and wantv
checks that don't seem very useful).
This is residual from the JAMA code and is not required with our current
interface.
I wonder if we could implement something around this. I can conceive of
cases where users may only want
Hi.
Also, I think that further cleanup is possible (cf. wantu and wantv
checks that don't seem very useful).
This is residual from the JAMA code and is not required with our current
interface.
I removed them in r1157281.
I wonder if we could implement something around this. I can
In the SVD class I notice:
FastMath.max(m, n)
all over the place. Since these values are known when the constructor is
called and are final, would anyone object to making the result a private
instance variable?
I see only 2 places: lines 557 and 569.
[In one of them it is
At least three with some code I checked in last night. The point is that
there is no reason to replicate the same thing over and over again.
-Greg
On Thu, Aug 11, 2011 at 6:33 AM, Gilles Sadowski
gil...@harfang.homelinux.org wrote:
In the SVD class I notice:
FastMath.max(m, n)
Hello All,
In the SVD class I notice:
FastMath.max(m, n)
all over the place. Since these values are known when the constructor is
called and are final, would anyone object to making the result a private
instance variable?
-Greg
On 8/10/11 3:51 PM, Greg Sterijevski wrote:
Hello All,
In the SVD class I notice:
FastMath.max(m, n)
all over the place. Since these values are known when the constructor is
called and are final, would anyone object to making the result a private
instance variable?
+1
(note change in
