Re: commons-csv git commit: Better ivar name.

2017-08-18 Thread Benedikt Ritter
IMHO that's a bad name as well :o) Gary Gregory schrieb am Fr. 18. Aug. 2017 um 17:37: > We already have header*Map* ... > > Gary > > On Fri, Aug 18, 2017 at 9:23 AM, Benedikt Ritter > wrote: > > > Hello, > > > > I don't think this is a better name.

Re: commons-csv git commit: Better ivar name.

2017-08-18 Thread Claude Warren
I have no problem calling it a *List if it is a list, but I also have to ask should it be a list. Why not just a Collection? Is order important? Are duplicates allowed (if not perhaps a Set is proper). On the other hand it is fairly localized so I am not concerned. As for the *Map I find that

Re: commons-csv git commit: Better ivar name.

2017-08-18 Thread Gary Gregory
We already have header*Map* ... Gary On Fri, Aug 18, 2017 at 9:23 AM, Benedikt Ritter wrote: > Hello, > > I don't think this is a better name. In my opinion it's bad style to add > types to variable names. How about recordContents or simply content/s ? > > Regards, >

Re: commons-csv git commit: Better ivar name.

2017-08-18 Thread Benedikt Ritter
Hello, I don't think this is a better name. In my opinion it's bad style to add types to variable names. How about recordContents or simply content/s ? Regards, Benedikt schrieb am Fr. 18. Aug. 2017 um 17:02: > Repository: commons-csv > Updated Branches: >